[Bug tree-optimization/98182] New: [11 Regression] ICE: Segmentation fault (in gimple_verify_flow_info)

[Bug tree-optimization/98182] New: [11 Regression] ICE: Segmentation fault (in gimple_verify_flow_info)

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98182

            Bug ID: 98182
           Summary: [11 Regression] ICE: Segmentation fault (in
                    gimple_verify_flow_info)
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---

gcc-11.0.0-alpha20201206 snapshot (g:9da33826bb9b7d76f85057c18a0b65d0e14baa3d)
ICEs when compiling gcc/testsuite/c-c++-common/Wmultistatement-macros-3.c w/
-O1 --param case-values-threshold=1:

% gcc-11.0.0 -O1 --param case-values-threshold=1 -c
gcc/testsuite/c-c++-common/Wmultistatement-macros-3.c
during GIMPLE pass: iftoswitch
gcc/testsuite/c-c++-common/Wmultistatement-macros-3.c: In function 'fn':
gcc/testsuite/c-c++-common/Wmultistatement-macros-3.c:12:1: internal compiler
error: Segmentation fault
   12 | }
      | ^
0xdeec7f crash_signal
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201206/work/gcc-11-20201206/gcc/toplev.c:327
0xe34ca4 gimple_verify_flow_info
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201206/work/gcc-11-20201206/gcc/tree-cfg.c:5701
0x9550ba verify_flow_info()
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201206/work/gcc-11-20201206/gcc/cfghooks.c:267
0xe412e4 checking_verify_flow_info
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201206/work/gcc-11-20201206/gcc/cfghooks.h:212
0xe412e4 cleanup_tree_cfg_noloop
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201206/work/gcc-11-20201206/gcc/tree-cfgcleanup.c:1136
0xe412e4 cleanup_tree_cfg(unsigned int)
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201206/work/gcc-11-20201206/gcc/tree-cfgcleanup.c:1187
0xd0dfc4 execute_function_todo
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201206/work/gcc-11-20201206/gcc/passes.c:2008
0xd0e93b execute_todo
       
/var/tmp/portage/sys-devel/gcc-11.0.0_alpha20201206/work/gcc-11-20201206/gcc/passes.c:2096

[Bug tree-optimization/98182] [11 Regression] ICE: Segmentation fault (in gimple_verify_flow_info)

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98182

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
                 CC|                            |marxin at gcc dot gnu.org
   Last reconfirmed|                            |2020-12-08
           Priority|P3                          |P1
   Target Milestone|---                         |11.0
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Mine.

[Bug tree-optimization/98182] [11 Regression] ICE: Segmentation fault (in gimple_verify_flow_info)

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98182

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Am testing a patch right now.

[Bug tree-optimization/98182] [11 Regression] ICE: Segmentation fault (in gimple_verify_flow_info)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98182

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:f7251a2c103bc48775cb9726a4bebeaebde96684

commit r11-5863-gf7251a2c103bc48775cb9726a4bebeaebde96684
Author: Martin Liska <mliska@suse.cz>
Date:   Tue Dec 8 13:18:37 2020 +0100

    if-to-switch: fix matching of negative conditions

    gcc/ChangeLog:

            PR tree-optimization/98182
            * gimple-if-to-switch.cc (pass_if_to_switch::execute): Request
            chain linkage through false edges only.

    gcc/testsuite/ChangeLog:

            PR tree-optimization/98182
            * gcc.dg/tree-ssa/if-to-switch-10.c: New test.
            * gcc.dg/tree-ssa/pr98182.c: New test.

[Bug tree-optimization/98182] [11 Regression] ICE: Segmentation fault (in gimple_verify_flow_info)

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98182

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed.

[Bug tree-optimization/98182] [11 Regression] ICE: Segmentation fault (in gimple_verify_flow_info)

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98182

Christophe Lyon <clyon at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clyon at gcc dot gnu.org

--- Comment #5 from Christophe Lyon <clyon at gcc dot gnu.org> ---
The new test if-to-switch-10.c fails on aarch64:
FAIL: gcc.dg/tree-ssa/if-to-switch-10.c scan-tree-dump iftoswitch "Condition
chain with [^\n\r]* BBs transformed into a switch statement."

[Bug tree-optimization/98182] [11 Regression] ICE: Segmentation fault (in gimple_verify_flow_info)

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98182

--- Comment #6 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Christophe Lyon from comment #5)
> The new test if-to-switch-10.c fails on aarch64:
> FAIL: gcc.dg/tree-ssa/if-to-switch-10.c scan-tree-dump iftoswitch "Condition
> chain with [^\n\r]* BBs transformed into a switch statement."

I can confirm that. The test will need --param case-values-threshold=5 as the
default for aarch64 is 17 if I see correctly.

Can you please check also the other test-cases (if-to-switch*.c), I bet they
will suffer from the same.

[Bug tree-optimization/98182] [11 Regression] ICE: Segmentation fault (in gimple_verify_flow_info)

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98182

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |marxin at gcc dot gnu.org
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #7 from Martin Liška <marxin at gcc dot gnu.org> ---
Let's reopen it now.

[Bug tree-optimization/98182] [11 Regression] ICE: Segmentation fault (in gimple_verify_flow_info)

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98182

--- Comment #8 from Christophe Lyon <clyon at gcc dot gnu.org> ---
Indeed if-to-switch-1.c fails on aarch64 too, the other ones pass.

[Bug tree-optimization/98182] [11 Regression] ICE: Segmentation fault (in gimple_verify_flow_info)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98182

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:33d2f41785b24ad43c5a9d52aa289e33ac838f86

commit r11-5883-g33d2f41785b24ad43c5a9d52aa289e33ac838f86
Author: Martin Liska <mliska@suse.cz>
Date:   Wed Dec 9 15:24:36 2020 +0100

    testsuite: fix 2 tests on aarch64

    gcc/testsuite/ChangeLog:

            PR tree-optimization/98182
            * gcc.dg/tree-ssa/if-to-switch-1.c: Add case-values-threshold in
            order to fix them for aarch64.
            * gcc.dg/tree-ssa/if-to-switch-10.c: Likewise.

[Bug tree-optimization/98182] [11 Regression] ICE: Segmentation fault (in gimple_verify_flow_info)

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98182

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Martin Liška <marxin at gcc dot gnu.org> ---
Should be fixed now.