public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/98183] [8/9/10 Regression] ICE in expand_gimple_stmt_1, at cfgexpand.c:3972 Date: Wed, 06 Jan 2021 09:39:49 +0000 [thread overview] Message-ID: <bug-98183-4-M8Ih9DA6wU@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-98183-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98183 --- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-10 branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:8c1ed7223ad1bc19ed9c936ba496220c8ef673bc commit r10-9220-g8c1ed7223ad1bc19ed9c936ba496220c8ef673bc Author: Jakub Jelinek <jakub@redhat.com> Date: Sat Dec 12 08:36:02 2020 +0100 openmp, openacc: Fix up handling of data regions [PR98183] While the data regions (target data and OpenACC counterparts) aren't standalone directives, unlike most other OpenMP/OpenACC constructs we allow (apparently as an extension) exceptions and goto out of the block. During gimplification we place an *end* call into a finally block so that it is reached even on exceptions or goto out etc.). During omplower pass we then add paired #pragma omp return for them, but due to the exceptions because the region is not SESE we can end up with #pragma omp return appearing only conditionally in the CFG etc., which the ompexp pass can't handle. For the ompexp pass, we actually don't care about the end part or about target data nesting, so we can treat it as standalone directive. 2020-12-12 Jakub Jelinek <jakub@redhat.com> PR middle-end/98183 * omp-low.c (lower_omp_target): Don't add OMP_RETURN for data regions. * omp-expand.c (expand_omp_target): Don't try to remove OMP_RETURN for data regions. (build_omp_regions_1, omp_make_gimple_edges): Don't expect OMP_RETURN for data regions. * gcc.dg/gomp/pr98183.c: New test. * gcc.dg/goacc/pr98183.c: New test. (cherry picked from commit cc9b9c0b68233d38a26f7acd68cc5f9a8fc4d994)
next prev parent reply other threads:[~2021-01-06 9:39 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-07 17:50 [Bug c/98183] New: [9/10/11 " gscfq@t-online.de 2020-12-08 5:27 ` [Bug c/98183] " marxin at gcc dot gnu.org 2020-12-08 7:20 ` rguenth at gcc dot gnu.org 2020-12-11 18:32 ` jakub at gcc dot gnu.org 2020-12-11 18:35 ` jakub at gcc dot gnu.org 2020-12-11 18:53 ` jakub at gcc dot gnu.org 2020-12-11 18:55 ` [Bug middle-end/98183] [8/9/10/11 " jakub at gcc dot gnu.org 2020-12-11 19:37 ` jakub at gcc dot gnu.org 2020-12-12 7:43 ` cvs-commit at gcc dot gnu.org 2020-12-14 9:57 ` [Bug middle-end/98183] [8/9/10 " jakub at gcc dot gnu.org 2021-01-06 9:39 ` cvs-commit at gcc dot gnu.org [this message] 2021-01-06 9:45 ` [Bug middle-end/98183] [8/9 " jakub at gcc dot gnu.org 2021-04-20 23:30 ` cvs-commit at gcc dot gnu.org 2021-04-22 16:49 ` cvs-commit at gcc dot gnu.org 2021-04-22 17:08 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-98183-4-M8Ih9DA6wU@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).