public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c++/98187] New: ICE in build_call_expr_loc_array, at tree.c:11554
@ 2020-12-07 17:59 gscfq@t-online.de
2020-12-07 20:28 ` [Bug c++/98187] " jakub at gcc dot gnu.org
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: gscfq@t-online.de @ 2020-12-07 17:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98187
Bug ID: 98187
Summary: ICE in build_call_expr_loc_array, at tree.c:11554
Product: gcc
Version: 11.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c++
Assignee: unassigned at gcc dot gnu.org
Reporter: gscfq@t-online.de
Target Milestone: ---
Using testfile c-c++-common/gomp/lastprivate-conditional-1.c
with option -fopenmp-simd and versions r10/r11 :
$ g++-11-20201206 -c lastprivate-conditional-1.c -fopenmp-simd
during GIMPLE pass: ompexp
lastprivate-conditional-1.c: In function 'void foo(int*)':
lastprivate-conditional-1.c:41:11: internal compiler error: Segmentation fault
41 | #pragma omp parallel master taskloop simd lastprivate (conditional:
h)
| ^~~
0xf7ce3f crash_signal
../../gcc/toplev.c:327
0x12ae048 contains_struct_check(tree_node*, tree_node_structure_enum, char
const*, int, char const*)
../../gcc/tree.h:3448
0x12ae048 build_call_expr_loc_array(unsigned int, tree_node*, int, tree_node**)
../../gcc/tree.c:11554
0x1ad57e8 expand_parallel_call
../../gcc/omp-expand.c:732
0x1ad65e6 expand_omp_taskreg
../../gcc/omp-expand.c:1485
0x1adefcf expand_omp_synch
../../gcc/omp-expand.c:8453
0x1adefcf expand_omp
../../gcc/omp-expand.c:9937
0x1ae128d execute_expand_omp
../../gcc/omp-expand.c:10133
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c++/98187] ICE in build_call_expr_loc_array, at tree.c:11554
2020-12-07 17:59 [Bug c++/98187] New: ICE in build_call_expr_loc_array, at tree.c:11554 gscfq@t-online.de
@ 2020-12-07 20:28 ` jakub at gcc dot gnu.org
2020-12-08 9:49 ` cvs-commit at gcc dot gnu.org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-12-07 20:28 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98187
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Ever confirmed|0 |1
Assignee|unassigned at gcc dot gnu.org |jakub at gcc dot gnu.org
Last reconfirmed| |2020-12-07
--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 49700
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49700&action=edit
gcc11-pr98187.patch
Untested fix.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c++/98187] ICE in build_call_expr_loc_array, at tree.c:11554
2020-12-07 17:59 [Bug c++/98187] New: ICE in build_call_expr_loc_array, at tree.c:11554 gscfq@t-online.de
2020-12-07 20:28 ` [Bug c++/98187] " jakub at gcc dot gnu.org
@ 2020-12-08 9:49 ` cvs-commit at gcc dot gnu.org
2020-12-08 9:58 ` jakub at gcc dot gnu.org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-12-08 9:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98187
--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:31007091b10944c358e5038a6271d7e2744cde37
commit r11-5842-g31007091b10944c358e5038a6271d7e2744cde37
Author: Jakub Jelinek <jakub@redhat.com>
Date: Tue Dec 8 10:45:30 2020 +0100
openmp: -fopenmp-simd fixes [PR98187]
This patch fixes two bugs in the -fopenmp-simd support. One is that
in C++ #pragma omp parallel master would actually create OMP_PARALLEL
in the IL, which is a big no-no for -fopenmp-simd, we should be creating
only the constructs -fopenmp-simd handles (mainly OMP_SIMD, OMP_LOOP which
is gimplified as simd in that case, declare simd/reduction and ordered
simd).
The other bug was that #pragma omp master taskloop simd combined construct
contains simd and thus should be recognized as #pragma omp simd (with only
the simd applicable clauses), but as master wasn't included in
omp_pragmas_simd, we'd ignore it completely instead.
2020-12-08 Jakub Jelinek <jakub@redhat.com>
PR c++/98187
* c-pragma.c (omp_pragmas): Remove "master".
(omp_pragmas_simd): Add "master".
* parser.c (cp_parser_omp_parallel): For parallel master with
-fopenmp-simd only, just call cp_parser_omp_master instead of
wrapping it in OMP_PARALLEL.
* c-c++-common/gomp/pr98187.c: New test.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c++/98187] ICE in build_call_expr_loc_array, at tree.c:11554
2020-12-07 17:59 [Bug c++/98187] New: ICE in build_call_expr_loc_array, at tree.c:11554 gscfq@t-online.de
2020-12-07 20:28 ` [Bug c++/98187] " jakub at gcc dot gnu.org
2020-12-08 9:49 ` cvs-commit at gcc dot gnu.org
@ 2020-12-08 9:58 ` jakub at gcc dot gnu.org
2020-12-08 10:00 ` jakub at gcc dot gnu.org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-12-08 9:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98187
--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
*** Bug 98186 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c++/98187] ICE in build_call_expr_loc_array, at tree.c:11554
2020-12-07 17:59 [Bug c++/98187] New: ICE in build_call_expr_loc_array, at tree.c:11554 gscfq@t-online.de
` (2 preceding siblings ...)
2020-12-08 9:58 ` jakub at gcc dot gnu.org
@ 2020-12-08 10:00 ` jakub at gcc dot gnu.org
2021-01-06 9:39 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2020-12-08 10:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98187
--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
*** Bug 98185 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c++/98187] ICE in build_call_expr_loc_array, at tree.c:11554
2020-12-07 17:59 [Bug c++/98187] New: ICE in build_call_expr_loc_array, at tree.c:11554 gscfq@t-online.de
` (3 preceding siblings ...)
2020-12-08 10:00 ` jakub at gcc dot gnu.org
@ 2021-01-06 9:39 ` cvs-commit at gcc dot gnu.org
2021-04-20 23:30 ` cvs-commit at gcc dot gnu.org
2021-04-22 13:31 ` jakub at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-01-06 9:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98187
--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:e315ba968d2a47643a9487ea48d62e6399a07d49
commit r10-9217-ge315ba968d2a47643a9487ea48d62e6399a07d49
Author: Jakub Jelinek <jakub@redhat.com>
Date: Tue Dec 8 10:45:30 2020 +0100
openmp: -fopenmp-simd fixes [PR98187]
This patch fixes two bugs in the -fopenmp-simd support. One is that
in C++ #pragma omp parallel master would actually create OMP_PARALLEL
in the IL, which is a big no-no for -fopenmp-simd, we should be creating
only the constructs -fopenmp-simd handles (mainly OMP_SIMD, OMP_LOOP which
is gimplified as simd in that case, declare simd/reduction and ordered
simd).
The other bug was that #pragma omp master taskloop simd combined construct
contains simd and thus should be recognized as #pragma omp simd (with only
the simd applicable clauses), but as master wasn't included in
omp_pragmas_simd, we'd ignore it completely instead.
2020-12-08 Jakub Jelinek <jakub@redhat.com>
PR c++/98187
* c-pragma.c (omp_pragmas): Remove "master".
(omp_pragmas_simd): Add "master".
* parser.c (cp_parser_omp_parallel): For parallel master with
-fopenmp-simd only, just call cp_parser_omp_master instead of
wrapping it in OMP_PARALLEL.
* c-c++-common/gomp/pr98187.c: New test.
(cherry picked from commit 31007091b10944c358e5038a6271d7e2744cde37)
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c++/98187] ICE in build_call_expr_loc_array, at tree.c:11554
2020-12-07 17:59 [Bug c++/98187] New: ICE in build_call_expr_loc_array, at tree.c:11554 gscfq@t-online.de
` (4 preceding siblings ...)
2021-01-06 9:39 ` cvs-commit at gcc dot gnu.org
@ 2021-04-20 23:30 ` cvs-commit at gcc dot gnu.org
2021-04-22 13:31 ` jakub at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-04-20 23:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98187
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:22b900e2db91095414832a83ae5761e689c676e7
commit r9-9399-g22b900e2db91095414832a83ae5761e689c676e7
Author: Jakub Jelinek <jakub@redhat.com>
Date: Tue Dec 8 10:45:30 2020 +0100
openmp: -fopenmp-simd fixes [PR98187]
This patch fixes two bugs in the -fopenmp-simd support. One is that
in C++ #pragma omp parallel master would actually create OMP_PARALLEL
in the IL, which is a big no-no for -fopenmp-simd, we should be creating
only the constructs -fopenmp-simd handles (mainly OMP_SIMD, OMP_LOOP which
is gimplified as simd in that case, declare simd/reduction and ordered
simd).
The other bug was that #pragma omp master taskloop simd combined construct
contains simd and thus should be recognized as #pragma omp simd (with only
the simd applicable clauses), but as master wasn't included in
omp_pragmas_simd, we'd ignore it completely instead.
2020-12-08 Jakub Jelinek <jakub@redhat.com>
PR c++/98187
* c-pragma.c (omp_pragmas): Remove "master".
(omp_pragmas_simd): Add "master".
* parser.c (cp_parser_omp_parallel): For parallel master with
-fopenmp-simd only, just call cp_parser_omp_master instead of
wrapping it in OMP_PARALLEL.
* c-c++-common/gomp/pr98187.c: New test.
(cherry picked from commit e315ba968d2a47643a9487ea48d62e6399a07d49)
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug c++/98187] ICE in build_call_expr_loc_array, at tree.c:11554
2020-12-07 17:59 [Bug c++/98187] New: ICE in build_call_expr_loc_array, at tree.c:11554 gscfq@t-online.de
` (5 preceding siblings ...)
2021-04-20 23:30 ` cvs-commit at gcc dot gnu.org
@ 2021-04-22 13:31 ` jakub at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-04-22 13:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98187
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-04-22 13:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-07 17:59 [Bug c++/98187] New: ICE in build_call_expr_loc_array, at tree.c:11554 gscfq@t-online.de
2020-12-07 20:28 ` [Bug c++/98187] " jakub at gcc dot gnu.org
2020-12-08 9:49 ` cvs-commit at gcc dot gnu.org
2020-12-08 9:58 ` jakub at gcc dot gnu.org
2020-12-08 10:00 ` jakub at gcc dot gnu.org
2021-01-06 9:39 ` cvs-commit at gcc dot gnu.org
2021-04-20 23:30 ` cvs-commit at gcc dot gnu.org
2021-04-22 13:31 ` jakub at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).