public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rsandifo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/98190] [11 Regression] GCC11 miscompiles code using _Bool when inlining: bfxil instruction misused since r11-165
Date: Wed, 09 Dec 2020 09:04:08 +0000	[thread overview]
Message-ID: <bug-98190-4-lmiNsDP5O0@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98190-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98190

--- Comment #10 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #9)
> Perhaps some of those checks on the other side are redundant and could be
> turned e.g. into gcc_checking_assert of gcc_assert, I bet if the MEM_REF
> doesn't overwrite all bits, but only some subset of them, then the
> destination couldn't be a nonmem decl and thus couldn't be promoted.
Yeah, asserting sounds good.  Checking the other conditions makes it
look like we could still fall through to the else for some promoted
subregs.

If we can't assert, I guess the rule is that we need to extend
whenever we're storing to the MSB of the inner register.  We can
do that either by extending the source value and the range to
the outer register, or by assigning to the inner register and
then extending it separately.

  parent reply	other threads:[~2020-12-09  9:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08  0:22 [Bug c/98190] New: GCC 11.0 miscompiles code using _Bool when inlining: bfxil instruction misused? vstinner at redhat dot com
2020-12-08  0:29 ` [Bug middle-end/98190] " pinskia at gcc dot gnu.org
2020-12-08  0:31 ` pinskia at gcc dot gnu.org
2020-12-08  0:33 ` vstinner at redhat dot com
2020-12-08  0:37 ` pinskia at gcc dot gnu.org
2020-12-08 13:08 ` jakub at gcc dot gnu.org
2020-12-08 13:55 ` [Bug middle-end/98190] [11 Regression] GCC11 miscompiles code using _Bool when inlining: bfxil instruction misused since r11-165 jakub at gcc dot gnu.org
2020-12-08 14:52 ` rguenth at gcc dot gnu.org
2020-12-08 19:07 ` jakub at gcc dot gnu.org
2020-12-08 19:16 ` jakub at gcc dot gnu.org
2020-12-09  9:04 ` rsandifo at gcc dot gnu.org [this message]
2020-12-09  9:16 ` rguenther at suse dot de
2020-12-09  9:41 ` jakub at gcc dot gnu.org
2020-12-09 15:03 ` rguenther at suse dot de
2020-12-09 16:30 ` rsandifo at gcc dot gnu.org
2020-12-10  8:22 ` jakub at gcc dot gnu.org
2020-12-10 11:39 ` rguenther at suse dot de
2020-12-11 10:12 ` cvs-commit at gcc dot gnu.org
2020-12-11 11:50 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-98190-4-lmiNsDP5O0@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).