public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/98190] [11 Regression] GCC11 miscompiles code using _Bool when inlining: bfxil instruction misused since r11-165
Date: Thu, 10 Dec 2020 11:39:38 +0000	[thread overview]
Message-ID: <bug-98190-4-rn9TykSLiX@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98190-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98190

--- Comment #16 from rguenther at suse dot de <rguenther at suse dot de> ---
On Thu, 10 Dec 2020, jakub at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98190
> 
> --- Comment #15 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
> Created attachment 49727
>   --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49727&action=edit
> gcc11-pr98190.patch
> 
> So, I have bootstrapped/regtested this patch last night on x86_64, i686,
> aarch64, armv7hl, powerpc64le (and s390x still pending) linux.
> Unfortunately, on aarch64 it regresses:
> gcc.c-torture/execute/pr93213.c
> and on powerpc64le that test plus:
> g++.dg/warn/Wstrict-aliasing-bogus-char-1.C
> gcc.dg/pr87273.c
> gcc.dg/torture/pr91656-1.c
> gcc.dg/tree-ssa/pr92085-2.c
> gcc.dg/tree-ssa/pr94703.c
> 
> Seems the assumption that for promoted SUBREG to_rtx the store is always to all
> the bits is incorrect, e.g. on pr93213.c  the memcpy is copying just half of
> the bits.  So, shall we check the bitpos 0 bitsize all to_rtx bits for the
> store_rtx case and otherwise check depending on endianity if the most
> significant bit of to_rtx is overwritten and extend in that case?

in foo() you mean?  For

  __builtin_memmove (&u16_1, &u128_1, 1);

?  So that's a parameter destination - does it at least have correctly
DECL_NOT_GIMPLE_REG_P set?  Did expansion really do sth different
when we had it TREE_ADDRESSABLE?

  parent reply	other threads:[~2020-12-10 11:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08  0:22 [Bug c/98190] New: GCC 11.0 miscompiles code using _Bool when inlining: bfxil instruction misused? vstinner at redhat dot com
2020-12-08  0:29 ` [Bug middle-end/98190] " pinskia at gcc dot gnu.org
2020-12-08  0:31 ` pinskia at gcc dot gnu.org
2020-12-08  0:33 ` vstinner at redhat dot com
2020-12-08  0:37 ` pinskia at gcc dot gnu.org
2020-12-08 13:08 ` jakub at gcc dot gnu.org
2020-12-08 13:55 ` [Bug middle-end/98190] [11 Regression] GCC11 miscompiles code using _Bool when inlining: bfxil instruction misused since r11-165 jakub at gcc dot gnu.org
2020-12-08 14:52 ` rguenth at gcc dot gnu.org
2020-12-08 19:07 ` jakub at gcc dot gnu.org
2020-12-08 19:16 ` jakub at gcc dot gnu.org
2020-12-09  9:04 ` rsandifo at gcc dot gnu.org
2020-12-09  9:16 ` rguenther at suse dot de
2020-12-09  9:41 ` jakub at gcc dot gnu.org
2020-12-09 15:03 ` rguenther at suse dot de
2020-12-09 16:30 ` rsandifo at gcc dot gnu.org
2020-12-10  8:22 ` jakub at gcc dot gnu.org
2020-12-10 11:39 ` rguenther at suse dot de [this message]
2020-12-11 10:12 ` cvs-commit at gcc dot gnu.org
2020-12-11 11:50 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-98190-4-rn9TykSLiX@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).