public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/98212] [10/11 Regression] X86 unoptimal code for float equallity comparison followed by jump Date: Wed, 09 Dec 2020 16:54:08 +0000 [thread overview] Message-ID: <bug-98212-4-neHz5BBRAD@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-98212-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98212 --- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> --- As for f2, only the case of a == b when the jump is predicted unlikely looks weird, e.g. take: void foo (void); void bar (float a, float b) { if (__builtin_expect (a != b, 1)) foo (); } void baz (float a, float b) { if (__builtin_expect (a == b, 1)) foo (); } void qux (float a, float b) { if (__builtin_expect (a != b, 0)) foo (); } void corge (float a, float b) { if (__builtin_expect (a == b, 0)) foo (); } bar: ucomiss %xmm1, %xmm0 jp .L4 je .L1 .L4: jmp foo .L1: ret baz: ucomiss %xmm1, %xmm0 jp .L6 jne .L6 jmp foo .L6: ret qux: ucomiss %xmm1, %xmm0 jp .L13 jne .L13 ret .L13: jmp foo corge: ucomiss %xmm1, %xmm0 jnp .L18 .L14: ret .L18: jne .L14 jmp foo I guess I need to debug the branch probabilities in that case, we should certainly predict that operands are most of the time non-NaN and thus that PF bit will not be set in 99% of cases or so.
next prev parent reply other threads:[~2020-12-09 16:54 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-09 10:07 [Bug rtl-optimization/98212] New: " denis.campredon at gmail dot com 2020-12-09 11:15 ` [Bug rtl-optimization/98212] " crazylht at gmail dot com 2020-12-09 12:46 ` [Bug rtl-optimization/98212] [10/11 Regression] " rguenth at gcc dot gnu.org 2020-12-09 12:50 ` ubizjak at gmail dot com 2020-12-09 14:43 ` jakub at gcc dot gnu.org 2020-12-09 16:54 ` jakub at gcc dot gnu.org [this message] 2020-12-09 19:10 ` jakub at gcc dot gnu.org 2020-12-09 19:43 ` jakub at gcc dot gnu.org 2020-12-10 11:04 ` cvs-commit at gcc dot gnu.org 2020-12-10 23:38 ` cvs-commit at gcc dot gnu.org 2020-12-10 23:40 ` [Bug rtl-optimization/98212] [10 " jakub at gcc dot gnu.org 2021-04-08 12:02 ` rguenth at gcc dot gnu.org 2022-06-28 10:42 ` jakub at gcc dot gnu.org 2023-07-07 9:19 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-98212-4-neHz5BBRAD@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).