public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/98237] gcc-dg-lto-modref-3-01.exe etc. FAIL when LTO plugin is not enabled
Date: Fri, 16 Feb 2024 08:48:18 +0000	[thread overview]
Message-ID: <bug-98237-4-1TFuijUBm0@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98237-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98237

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Rainer Orth <ro@gcc.gnu.org>:

https://gcc.gnu.org/g:de658585d6dcc89f1cba71ef5f8f5b55719a7054

commit r14-9024-gde658585d6dcc89f1cba71ef5f8f5b55719a7054
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Fri Feb 16 09:47:35 2024 +0100

    testsuite: Require lto-plugin support in gcc.dg/lto/modref-3 etc. [PR98237]

    gcc.dg/lto/modref-3 etc. FAIL on Solaris with the native linker:

    FAIL: gcc-dg-lto-modref-3-01.exe scan-wpa-ipa-dump modref "parm 1 flags:
no_direct_clobber no_direct_escape"
    FAIL: gcc-dg-lto-modref-4-01.exe scan-wpa-ipa-dump modref "parm 1 flags:
no_direct_clobber no_direct_escape"
    FAIL: gcc.dg/lto/modref-3 c_lto_modref-3_0.o-c_lto_modref-3_1.o execute -O2
-flto-partition=max -fdump-ipa-modref -fno-ipa-sra -fno-ipa-cp -flto
    FAIL: gcc.dg/lto/modref-4 c_lto_modref-4_0.o-c_lto_modref-4_1.o execute -O2
-flto-partition=max -fdump-ipa-modref -fno-ipa-sra -flto

    The issue is that the tests require the linker plugin, which isn't
    available with Solaris ld.  Thus, it also FAILs when gcc is configured
    with --disable-lto-plugin.

    This patch thus declares the requirement.  As it turns out, there's an
    undocumented dg-require-linker-plugin already, but I introduce and use
    the corresponding effective-target keyword and document both.

    Given that the effective-target form is more flexible, I'm tempted to
    remove dg-require-* with an empty arg as already mentioned in
    sourcebuild.texi.  That is not this patch, however.

    Tested on i386-pc-solaris2.11 with ld and gld.

    2024-02-14  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

            gcc/testsuite:
            PR ipa/98237
            * lib/target-supports.exp (is-effective-target): Handle
            linker_plugin.
            * gcc.dg/lto/modref-3_0.c: Require linker_plugin support.
            * gcc.dg/lto/modref-4_0.c: Likewise.

            gcc:
            * doc/sourcebuild.texi (Effective-Target Keywords, Other
            attribugs): Document linker_plugin.
            (Require Support): Document dg-require-linker-plugin.

  parent reply	other threads:[~2024-02-16  8:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-11 11:58 [Bug ipa/98237] New: gcc-dg-lto-modref-3-01.exe etc. FAIL ro at gcc dot gnu.org
2020-12-11 11:58 ` [Bug ipa/98237] " ro at gcc dot gnu.org
2020-12-11 12:17 ` ro at gcc dot gnu.org
2021-04-27 11:39 ` jakub at gcc dot gnu.org
2021-07-28  7:05 ` rguenth at gcc dot gnu.org
2022-04-21  7:48 ` [Bug ipa/98237] gcc-dg-lto-modref-3-01.exe etc. FAIL when LTO plugin is not enabled rguenth at gcc dot gnu.org
2023-05-29 10:03 ` jakub at gcc dot gnu.org
2024-02-16  8:48 ` cvs-commit at gcc dot gnu.org [this message]
2024-02-16  8:49 ` ro at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-98237-4-1TFuijUBm0@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).