[Bug c++/98315] New: [11 regression] libcody breaks Solaris bootstrap

[Bug c++/98315] New: [11 regression] libcody breaks Solaris bootstrap

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315

            Bug ID: 98315
           Summary: [11 regression] libcody breaks Solaris bootstrap
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: nathan at gcc dot gnu.org
  Target Milestone: ---
            Target: *-*-solaris2.11

Since the introduction of libcody, Solaris 11 bootstrap is broken:

* On Solaris 11.4:

In file included from /usr/include/sys/socket.h:25,
                 from /vol/gcc/src/hg/master/local/gcc/../libcody/cody.hh:29,
                 from /vol/gcc/src/hg/master/local/gcc/cp/mapper-client.h:26,
                 from /vol/gcc/src/hg/master/local/gcc/cp/mapper-client.cc:26:
/usr/include/sys/uio.h:192:3: error: attempt to use poisoned "bzero"
   bzero(&(xuiop)->xu_hint, sizeof ((xuiop)->xu_hint)); \
   ^

  where <sys/uio.h> has

/*
 * Clear the hints portion of an xuio_t, leaving the initial uio_t and the
 * xu_ext union untouched.
 *
 * Note that this does not touch xu_type.  Since zero copy is recognized as
 * UIO_XUIO with xu_type of UIOTYPE_ZEROCOPY, if extending a uio_t not setup
 * for zero copy into a full xuio_t then chances are that xu_type should be
 * initialized too as if the xuio_t had been bzero'd - ie to UIOTYPE_ASYNCIO.
 */
#define XUIO_BZERO_HINTS(xuiop) do { \
                bzero(&(xuiop)->xu_hint, sizeof ((xuiop)->xu_hint)); \
        _NOTE(CONSTCOND) } while (0)

  This macros isn't used anywhere, so I wonder why #pragma poison would be
  offended.

* On Solaris 11.3:

In file included from /usr/include/sys/stream.h:16,
                 from /usr/include/netinet/in.h:66,
                 from /usr/include/sys/socket.h:32,
                 from /vol/gcc/src/hg/master/local/gcc/../libcody/cody.hh:29,
                 from /vol/gcc/src/hg/master/local/gcc/cp/mapper-client.h:26,
                 from /vol/gcc/src/hg/master/local/gcc/cp/mapper-client.cc:26:
/usr/include/sys/strmdep.h:25:26: error: attempt to use poisoned "bcopy"
 #define strbcpy(s, d, c) bcopy(s, d, c)
                          ^

  with the following in <sys/strmdep.h>:

/*
 * Copy data from one data buffer to another.
 * The addresses must be word aligned - if not, use bcopy!
 */
#define strbcpy(s, d, c)        bcopy(s, d, c)

I've hacked around both for no by removing bcopy and bzero from #pragma GCC
poison
in gcc/system.h.

[Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0

[Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap

[nathan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315

Nathan Sidwell <nathan at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2020-12-16
           Assignee|unassigned at gcc dot gnu.org      |nathan at gcc dot gnu.org
     Ever confirmed|0                           |1

[Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap

[nathan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315

--- Comment #1 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
I think this is fixed by 
6ff747f023c 2020-12-16 | c++: Fix (some) solaris breakage

please let me know

[Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315

--- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #1 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
> I think this is fixed by 
> 6ff747f023c 2020-12-16 | c++: Fix (some) solaris breakage
>
> please let me know

Unfortunately not: there are still two instances of the problem:

In file included from /usr/include/sys/socket.h:25,
                 from /vol/gcc/src/hg/master/local/gcc/../libcody/cody.hh:29,
                 from
/vol/gcc/src/hg/master/local/gcc/cp/../../c++tools/resolver.h:25,
                 from
/vol/gcc/src/hg/master/local/gcc/cp/../../c++tools/resolver.cc:23,
                 from
/vol/gcc/src/hg/master/local/gcc/cp/mapper-resolver.cc:27:
/usr/include/sys/uio.h:192:3: error: attempt to use poisoned "bzero"
   bzero(&(xuiop)->xu_hint, sizeof ((xuiop)->xu_hint)); \
   ^
In file included from /usr/include/sys/socket.h:25,
                 from /vol/gcc/src/hg/master/local/gcc/../libcody/cody.hh:29,
                 from /vol/gcc/src/hg/master/local/gcc/cp/mapper-client.h:26,
                 from /vol/gcc/src/hg/master/local/gcc/cp/module.cc:232:
/usr/include/sys/uio.h:192:3: error: attempt to use poisoned "bzero"
   bzero(&(xuiop)->xu_hint, sizeof ((xuiop)->xu_hint)); \
   ^

[Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap

[nathan at acm dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315

--- Comment #3 from Nathan Sidwell <nathan at acm dot org> ---
On 12/16/20 12:26 PM, ro at CeBiTec dot Uni-Bielefeld.DE wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315
> 
> --- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
>> --- Comment #1 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
>> I think this is fixed by
>> 6ff747f023c 2020-12-16 | c++: Fix (some) solaris breakage
>>
>> please let me know
> 
> Unfortunately not: there are still two instances of the problem:


There is another path to get to a poisoned bcopy.  Fixed thusly.

        gcc/cp/
         * mapper-resolver.cc: #include sys/socket before system.h
         due to poisoned bcopy use.

pushed to trunk

[Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap

[nathan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315

--- Comment #4 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
Another fix: 269e82d49e2

[Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315

--- Comment #5 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #3 from Nathan Sidwell <nathan at acm dot org> ---
[...]
>> Unfortunately not: there are still two instances of the problem:
>
> There is another path to get to a poisoned bcopy.  Fixed thusly.
>
>         gcc/cp/
>          * mapper-resolver.cc: #include sys/socket before system.h
>          due to poisoned bcopy use.

Thanks.  But doesn't gcc/cp/module.cc need a similar treatment to deal
with the second part?

In file included from /usr/include/sys/socket.h:25,
                 from /vol/gcc/src/hg/master/local/gcc/../libcody/cody.hh:29,
                 from /vol/gcc/src/hg/master/local/gcc/cp/mapper-client.h:26,
                 from /vol/gcc/src/hg/master/local/gcc/cp/module.cc:232:
/usr/include/sys/uio.h:192:3: error: attempt to use poisoned "bzero"
   bzero(&(xuiop)->xu_hint, sizeof ((xuiop)->xu_hint)); \
   ^

[Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap

[nathan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315

--- Comment #6 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
gah!  there was me thinking the only networking thing in cp is
mapper-client.cc.  (It's the only thing that cares about networking.  That
mapper-resolver.cc needed a tweak should have clued me in

[Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap

[nathan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315

--- Comment #7 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
sorry for not getting this right sooner:

b7b6879f0b5: c++: Another solaris header use [PR 98315]

[Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315

--- Comment #8 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #7 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
> sorry for not getting this right sooner:
>
> b7b6879f0b5: c++: Another solaris header use [PR 98315]

No worries: I've now completed Solaris 11.3 and 11.4 bootstraps, so
everything is fine again.

Thanks.

[Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap

[nathan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315

Nathan Sidwell <nathan at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #9 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
thanks for confirming