public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c++/98315] New: [11 regression] libcody breaks Solaris bootstrap
@ 2020-12-16 10:07 ro at gcc dot gnu.org
2020-12-16 10:08 ` [Bug c++/98315] " ro at gcc dot gnu.org
` (10 more replies)
0 siblings, 11 replies; 12+ messages in thread
From: ro at gcc dot gnu.org @ 2020-12-16 10:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315
Bug ID: 98315
Summary: [11 regression] libcody breaks Solaris bootstrap
Product: gcc
Version: 11.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c++
Assignee: unassigned at gcc dot gnu.org
Reporter: ro at gcc dot gnu.org
CC: nathan at gcc dot gnu.org
Target Milestone: ---
Target: *-*-solaris2.11
Since the introduction of libcody, Solaris 11 bootstrap is broken:
* On Solaris 11.4:
In file included from /usr/include/sys/socket.h:25,
from /vol/gcc/src/hg/master/local/gcc/../libcody/cody.hh:29,
from /vol/gcc/src/hg/master/local/gcc/cp/mapper-client.h:26,
from /vol/gcc/src/hg/master/local/gcc/cp/mapper-client.cc:26:
/usr/include/sys/uio.h:192:3: error: attempt to use poisoned "bzero"
bzero(&(xuiop)->xu_hint, sizeof ((xuiop)->xu_hint)); \
^
where <sys/uio.h> has
/*
* Clear the hints portion of an xuio_t, leaving the initial uio_t and the
* xu_ext union untouched.
*
* Note that this does not touch xu_type. Since zero copy is recognized as
* UIO_XUIO with xu_type of UIOTYPE_ZEROCOPY, if extending a uio_t not setup
* for zero copy into a full xuio_t then chances are that xu_type should be
* initialized too as if the xuio_t had been bzero'd - ie to UIOTYPE_ASYNCIO.
*/
#define XUIO_BZERO_HINTS(xuiop) do { \
bzero(&(xuiop)->xu_hint, sizeof ((xuiop)->xu_hint)); \
_NOTE(CONSTCOND) } while (0)
This macros isn't used anywhere, so I wonder why #pragma poison would be
offended.
* On Solaris 11.3:
In file included from /usr/include/sys/stream.h:16,
from /usr/include/netinet/in.h:66,
from /usr/include/sys/socket.h:32,
from /vol/gcc/src/hg/master/local/gcc/../libcody/cody.hh:29,
from /vol/gcc/src/hg/master/local/gcc/cp/mapper-client.h:26,
from /vol/gcc/src/hg/master/local/gcc/cp/mapper-client.cc:26:
/usr/include/sys/strmdep.h:25:26: error: attempt to use poisoned "bcopy"
#define strbcpy(s, d, c) bcopy(s, d, c)
^
with the following in <sys/strmdep.h>:
/*
* Copy data from one data buffer to another.
* The addresses must be word aligned - if not, use bcopy!
*/
#define strbcpy(s, d, c) bcopy(s, d, c)
I've hacked around both for no by removing bcopy and bzero from #pragma GCC
poison
in gcc/system.h.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap
2020-12-16 10:07 [Bug c++/98315] New: [11 regression] libcody breaks Solaris bootstrap ro at gcc dot gnu.org
@ 2020-12-16 10:08 ` ro at gcc dot gnu.org
2020-12-16 12:59 ` nathan at gcc dot gnu.org
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: ro at gcc dot gnu.org @ 2020-12-16 10:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |11.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap
2020-12-16 10:07 [Bug c++/98315] New: [11 regression] libcody breaks Solaris bootstrap ro at gcc dot gnu.org
2020-12-16 10:08 ` [Bug c++/98315] " ro at gcc dot gnu.org
@ 2020-12-16 12:59 ` nathan at gcc dot gnu.org
2020-12-16 14:27 ` nathan at gcc dot gnu.org
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: nathan at gcc dot gnu.org @ 2020-12-16 12:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315
Nathan Sidwell <nathan at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2020-12-16
Assignee|unassigned at gcc dot gnu.org |nathan at gcc dot gnu.org
Ever confirmed|0 |1
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap
2020-12-16 10:07 [Bug c++/98315] New: [11 regression] libcody breaks Solaris bootstrap ro at gcc dot gnu.org
2020-12-16 10:08 ` [Bug c++/98315] " ro at gcc dot gnu.org
2020-12-16 12:59 ` nathan at gcc dot gnu.org
@ 2020-12-16 14:27 ` nathan at gcc dot gnu.org
2020-12-16 17:26 ` ro at CeBiTec dot Uni-Bielefeld.DE
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: nathan at gcc dot gnu.org @ 2020-12-16 14:27 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315
--- Comment #1 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
I think this is fixed by
6ff747f023c 2020-12-16 | c++: Fix (some) solaris breakage
please let me know
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap
2020-12-16 10:07 [Bug c++/98315] New: [11 regression] libcody breaks Solaris bootstrap ro at gcc dot gnu.org
` (2 preceding siblings ...)
2020-12-16 14:27 ` nathan at gcc dot gnu.org
@ 2020-12-16 17:26 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-12-16 17:41 ` nathan at acm dot org
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: ro at CeBiTec dot Uni-Bielefeld.DE @ 2020-12-16 17:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315
--- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #1 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
> I think this is fixed by
> 6ff747f023c 2020-12-16 | c++: Fix (some) solaris breakage
>
> please let me know
Unfortunately not: there are still two instances of the problem:
In file included from /usr/include/sys/socket.h:25,
from /vol/gcc/src/hg/master/local/gcc/../libcody/cody.hh:29,
from
/vol/gcc/src/hg/master/local/gcc/cp/../../c++tools/resolver.h:25,
from
/vol/gcc/src/hg/master/local/gcc/cp/../../c++tools/resolver.cc:23,
from
/vol/gcc/src/hg/master/local/gcc/cp/mapper-resolver.cc:27:
/usr/include/sys/uio.h:192:3: error: attempt to use poisoned "bzero"
bzero(&(xuiop)->xu_hint, sizeof ((xuiop)->xu_hint)); \
^
In file included from /usr/include/sys/socket.h:25,
from /vol/gcc/src/hg/master/local/gcc/../libcody/cody.hh:29,
from /vol/gcc/src/hg/master/local/gcc/cp/mapper-client.h:26,
from /vol/gcc/src/hg/master/local/gcc/cp/module.cc:232:
/usr/include/sys/uio.h:192:3: error: attempt to use poisoned "bzero"
bzero(&(xuiop)->xu_hint, sizeof ((xuiop)->xu_hint)); \
^
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap
2020-12-16 10:07 [Bug c++/98315] New: [11 regression] libcody breaks Solaris bootstrap ro at gcc dot gnu.org
` (3 preceding siblings ...)
2020-12-16 17:26 ` ro at CeBiTec dot Uni-Bielefeld.DE
@ 2020-12-16 17:41 ` nathan at acm dot org
2020-12-16 17:42 ` nathan at gcc dot gnu.org
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: nathan at acm dot org @ 2020-12-16 17:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315
--- Comment #3 from Nathan Sidwell <nathan at acm dot org> ---
On 12/16/20 12:26 PM, ro at CeBiTec dot Uni-Bielefeld.DE wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315
>
> --- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
>> --- Comment #1 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
>> I think this is fixed by
>> 6ff747f023c 2020-12-16 | c++: Fix (some) solaris breakage
>>
>> please let me know
>
> Unfortunately not: there are still two instances of the problem:
There is another path to get to a poisoned bcopy. Fixed thusly.
gcc/cp/
* mapper-resolver.cc: #include sys/socket before system.h
due to poisoned bcopy use.
pushed to trunk
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap
2020-12-16 10:07 [Bug c++/98315] New: [11 regression] libcody breaks Solaris bootstrap ro at gcc dot gnu.org
` (4 preceding siblings ...)
2020-12-16 17:41 ` nathan at acm dot org
@ 2020-12-16 17:42 ` nathan at gcc dot gnu.org
2020-12-16 17:53 ` ro at CeBiTec dot Uni-Bielefeld.DE
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: nathan at gcc dot gnu.org @ 2020-12-16 17:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315
--- Comment #4 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
Another fix: 269e82d49e2
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap
2020-12-16 10:07 [Bug c++/98315] New: [11 regression] libcody breaks Solaris bootstrap ro at gcc dot gnu.org
` (5 preceding siblings ...)
2020-12-16 17:42 ` nathan at gcc dot gnu.org
@ 2020-12-16 17:53 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-12-16 19:26 ` nathan at gcc dot gnu.org
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: ro at CeBiTec dot Uni-Bielefeld.DE @ 2020-12-16 17:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315
--- Comment #5 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #3 from Nathan Sidwell <nathan at acm dot org> ---
[...]
>> Unfortunately not: there are still two instances of the problem:
>
> There is another path to get to a poisoned bcopy. Fixed thusly.
>
> gcc/cp/
> * mapper-resolver.cc: #include sys/socket before system.h
> due to poisoned bcopy use.
Thanks. But doesn't gcc/cp/module.cc need a similar treatment to deal
with the second part?
In file included from /usr/include/sys/socket.h:25,
from /vol/gcc/src/hg/master/local/gcc/../libcody/cody.hh:29,
from /vol/gcc/src/hg/master/local/gcc/cp/mapper-client.h:26,
from /vol/gcc/src/hg/master/local/gcc/cp/module.cc:232:
/usr/include/sys/uio.h:192:3: error: attempt to use poisoned "bzero"
bzero(&(xuiop)->xu_hint, sizeof ((xuiop)->xu_hint)); \
^
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap
2020-12-16 10:07 [Bug c++/98315] New: [11 regression] libcody breaks Solaris bootstrap ro at gcc dot gnu.org
` (6 preceding siblings ...)
2020-12-16 17:53 ` ro at CeBiTec dot Uni-Bielefeld.DE
@ 2020-12-16 19:26 ` nathan at gcc dot gnu.org
2020-12-16 19:58 ` nathan at gcc dot gnu.org
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: nathan at gcc dot gnu.org @ 2020-12-16 19:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315
--- Comment #6 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
gah! there was me thinking the only networking thing in cp is
mapper-client.cc. (It's the only thing that cares about networking. That
mapper-resolver.cc needed a tweak should have clued me in
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap
2020-12-16 10:07 [Bug c++/98315] New: [11 regression] libcody breaks Solaris bootstrap ro at gcc dot gnu.org
` (7 preceding siblings ...)
2020-12-16 19:26 ` nathan at gcc dot gnu.org
@ 2020-12-16 19:58 ` nathan at gcc dot gnu.org
2020-12-17 12:22 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-12-17 21:35 ` nathan at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: nathan at gcc dot gnu.org @ 2020-12-16 19:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315
--- Comment #7 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
sorry for not getting this right sooner:
b7b6879f0b5: c++: Another solaris header use [PR 98315]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap
2020-12-16 10:07 [Bug c++/98315] New: [11 regression] libcody breaks Solaris bootstrap ro at gcc dot gnu.org
` (8 preceding siblings ...)
2020-12-16 19:58 ` nathan at gcc dot gnu.org
@ 2020-12-17 12:22 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-12-17 21:35 ` nathan at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: ro at CeBiTec dot Uni-Bielefeld.DE @ 2020-12-17 12:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315
--- Comment #8 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #7 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
> sorry for not getting this right sooner:
>
> b7b6879f0b5: c++: Another solaris header use [PR 98315]
No worries: I've now completed Solaris 11.3 and 11.4 bootstraps, so
everything is fine again.
Thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug c++/98315] [11 regression] libcody breaks Solaris bootstrap
2020-12-16 10:07 [Bug c++/98315] New: [11 regression] libcody breaks Solaris bootstrap ro at gcc dot gnu.org
` (9 preceding siblings ...)
2020-12-17 12:22 ` ro at CeBiTec dot Uni-Bielefeld.DE
@ 2020-12-17 21:35 ` nathan at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: nathan at gcc dot gnu.org @ 2020-12-17 21:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98315
Nathan Sidwell <nathan at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #9 from Nathan Sidwell <nathan at gcc dot gnu.org> ---
thanks for confirming
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-12-17 21:35 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-16 10:07 [Bug c++/98315] New: [11 regression] libcody breaks Solaris bootstrap ro at gcc dot gnu.org
2020-12-16 10:08 ` [Bug c++/98315] " ro at gcc dot gnu.org
2020-12-16 12:59 ` nathan at gcc dot gnu.org
2020-12-16 14:27 ` nathan at gcc dot gnu.org
2020-12-16 17:26 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-12-16 17:41 ` nathan at acm dot org
2020-12-16 17:42 ` nathan at gcc dot gnu.org
2020-12-16 17:53 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-12-16 19:26 ` nathan at gcc dot gnu.org
2020-12-16 19:58 ` nathan at gcc dot gnu.org
2020-12-17 12:22 ` ro at CeBiTec dot Uni-Bielefeld.DE
2020-12-17 21:35 ` nathan at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).