public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/98330] [11 Regression] ICE in compute_parm_map, at ipa-modref.c:2900 since r9-2640-g3d78e00879b42574
Date: Tue, 19 Jan 2021 14:13:51 +0000	[thread overview]
Message-ID: <bug-98330-4-PCgjQSFLHa@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98330-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98330

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Jan Hubicka from comment #8)
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98330
> > 
> > --- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
> > So modref allocates a fnspec_summary for an unknown indirect call (NULL callee)
> > but then in compute_parm_map calls function_or_virtual_thunk_symbol on
> > that NULL callee unconditionally.  We have a meaningful fnspec for the
> > call because the call type has a 'fn spec' attribute attached.
> > 
> > So I'm proposing the following which avoids the ICE (and undefined behavior
> > calling a member fn on a NULL object)
> 
> That looks OK.  We do not expect fnspecs on types of indirect calls (we
> probably should, I just did not expected them to exist) but then we can
> always recover them from type.  I suppose we do not need per-call-stmt
> sensitive fnspec attributes on indirect calls, right?

Right.

> Honza

  parent reply	other threads:[~2021-01-19 14:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-16 18:34 [Bug c++/98330] New: [11 Regression] ICE in compute_parm_map, at ipa-modref.c:2900 gscfq@t-online.de
2020-12-17 11:14 ` [Bug c++/98330] " marxin at gcc dot gnu.org
2021-01-04 15:33 ` rguenth at gcc dot gnu.org
2021-01-06 11:47 ` [Bug c++/98330] [9/10/11 Regression] ICE in compute_parm_map, at ipa-modref.c:2900 since r9-2640-g3d78e00879b42574 marxin at gcc dot gnu.org
2021-01-19 13:18 ` rguenth at gcc dot gnu.org
2021-01-19 13:29   ` Jan Hubicka
2021-01-19 13:20 ` [Bug c++/98330] [11 " rguenth at gcc dot gnu.org
2021-01-19 13:25 ` marxin at gcc dot gnu.org
2021-01-19 13:28 ` rguenth at gcc dot gnu.org
2021-01-19 13:29 ` hubicka at ucw dot cz
2021-01-19 14:13 ` rguenth at gcc dot gnu.org [this message]
2021-01-19 14:50 ` cvs-commit at gcc dot gnu.org
2021-01-19 14:51 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-98330-4-PCgjQSFLHa@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).