public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/98355] [9/10/11 Regression] ICE in has_attribute, at c-family/c-attribs.c:5628
Date: Mon, 01 Feb 2021 15:21:43 +0000 [thread overview]
Message-ID: <bug-98355-4-wsqRFfZL2N@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98355-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98355
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>:
https://gcc.gnu.org/g:bab669f2fc643cb1673aecd177eec1c773e9e48e
commit r11-7012-gbab669f2fc643cb1673aecd177eec1c773e9e48e
Author: Marek Polacek <polacek@redhat.com>
Date: Fri Jan 29 11:29:25 2021 -0500
c++: Improve sorry for __builtin_has_attribute [PR98355]
__builtin_has_attribute doesn't work in templates yet (bug 92104), so
in r11-471 I added a sorry. But that only caught type-dependent
expressions and we also want to sorry on value-dependent expressions.
This patch uses uses_template_parms, but guarded with p_t_d, because
u_t_p sets p_t_d and then v_d_e_p considers variables with reference
types value-dependent, which breaks builtin-has-attribute-6.c.
This is a regression and I also plan to apply this to gcc-10.
gcc/cp/ChangeLog:
PR c++/98355
* parser.c (cp_parser_has_attribute_expression): Use
uses_template_parms instead of type_dependent_expression_p.
gcc/testsuite/ChangeLog:
PR c++/98355
* g++.dg/ext/builtin-has-attribute2.C: New test.
next prev parent reply other threads:[~2021-02-01 15:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 16:51 [Bug c++/98355] New: " gscfq@t-online.de
2020-12-17 17:25 ` [Bug c++/98355] " msebor at gcc dot gnu.org
2021-01-05 8:34 ` rguenth at gcc dot gnu.org
2021-01-14 11:13 ` rguenth at gcc dot gnu.org
2021-01-19 14:59 ` jakub at gcc dot gnu.org
2021-01-19 16:33 ` msebor at gcc dot gnu.org
2021-01-29 4:41 ` mpolacek at gcc dot gnu.org
2021-01-29 16:34 ` mpolacek at gcc dot gnu.org
2021-02-01 15:21 ` cvs-commit at gcc dot gnu.org [this message]
2021-02-01 15:22 ` [Bug c++/98355] [9/10 " mpolacek at gcc dot gnu.org
2021-02-01 15:23 ` cvs-commit at gcc dot gnu.org
2021-02-01 15:23 ` [Bug c++/98355] [9 " mpolacek at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-98355-4-wsqRFfZL2N@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).