public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "unlvsur at live dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/98374] No #include <langinfo.h> on windows. Bootstrapping failure
Date: Sat, 19 Dec 2020 02:01:25 +0000 [thread overview]
Message-ID: <bug-98374-4-XlRoHVyiLg@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98374-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98374
cqwrteur <unlvsur at live dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from cqwrteur <unlvsur at live dot com> ---
(In reply to CVS Commits from comment #2)
> The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:
>
> https://gcc.gnu.org/g:d7bab388b818fc21dbb9111311e114ae33e11fff
>
> commit r11-6259-gd7bab388b818fc21dbb9111311e114ae33e11fff
> Author: Patrick Palka <ppalka@redhat.com>
> Date: Fri Dec 18 11:52:17 2020 -0500
>
> libstdc++: Fix build failure due to missing <langinfo.h> [PR98374]
>
> This should fix a build failure on Windows which lacks <langinfo.h>,
> from which we use nl_langinfo() to obtain the radix character of the
> current locale. (We can't use the more portable localeconv() from
> <clocale> to obtain the radix character of the current locale here
> because it's not thread-safe, unfortunately.)
>
> This change means that on Windows and other such platforms, we'll just
> always assume the radix character used by printf is '.' when formatting
> a long double through it.
>
> libstdc++-v3/ChangeLog:
>
> PR libstdc++/98374
> * src/c++17/floating_to_chars.cc: Guard include of <langinfo.h>
> with __has_include.
> (__floating_to_chars_precision) [!defined(RADIXCHAR)]: Don't
> attempt to obtain the radix character of the current locale,
> just assume it's '.'.
Fixed
next prev parent reply other threads:[~2020-12-19 2:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 14:57 [Bug libstdc++/98374] New: " unlvsur at live dot com
2020-12-18 15:12 ` [Bug libstdc++/98374] " ppalka at gcc dot gnu.org
2020-12-18 16:04 ` ppalka at gcc dot gnu.org
2020-12-18 16:55 ` cvs-commit at gcc dot gnu.org
2020-12-19 2:01 ` unlvsur at live dot com [this message]
2020-12-20 18:58 ` redi at gcc dot gnu.org
2020-12-21 0:02 ` unlvsur at live dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-98374-4-XlRoHVyiLg@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).