[Bug target/98403] New: [11 Regression] ICE: in add_def, at rtl-ssa/accesses.cc:837 with -Og -march=goldmont -fPIC -fcse-follow-jumps -fipa-ra -mforce-indirect-call

[Bug target/98403] New: [11 Regression] ICE: in add_def, at rtl-ssa/accesses.cc:837 with -Og -march=goldmont -fPIC -fcse-follow-jumps -fipa-ra -mforce-indirect-call

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98403

            Bug ID: 98403
           Summary: [11 Regression] ICE: in add_def, at
                    rtl-ssa/accesses.cc:837 with -Og -march=goldmont -fPIC
                    -fcse-follow-jumps -fipa-ra -mforce-indirect-call
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu

Created attachment 49815
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49815&action=edit
auto-reduced testcase (from OpenTTD sources)

Compiler output:
$ x86_64-pc-linux-gnu-gcc -Og -march=goldmont -fPIC -fcse-follow-jumps -fipa-ra
-mforce-indirect-call ai_gui.ii
during RTL pass: fwprop1
ai_gui.ii: In function 'void __static_initialization_and_destruction_0(int,
int)':
ai_gui.ii:191:58: internal compiler error: in add_def, at
rtl-ssa/accesses.cc:837
  191 |                                         SetDataTip(2, 3)};
      |                                                          ^
0xa44aac rtl_ssa::function_info::add_def(rtl_ssa::def_info*)
        /repo/gcc-trunk/gcc/rtl-ssa/accesses.cc:837
0x1e06fed rtl_ssa::function_info::apply_changes_to_insn(rtl_ssa::insn_change&)
        /repo/gcc-trunk/gcc/rtl-ssa/changes.cc:540
0x1e0976f
rtl_ssa::function_info::change_insns(array_slice<rtl_ssa::insn_change*>)
        /repo/gcc-trunk/gcc/rtl-ssa/changes.cc:707
0x1e09957 rtl_ssa::function_info::change_insn(rtl_ssa::insn_change&)
        /repo/gcc-trunk/gcc/rtl-ssa/changes.cc:715
0x1cdea78 try_fwprop_subst_pattern
        /repo/gcc-trunk/gcc/fwprop.c:530
0x1cdea78 try_fwprop_subst
        /repo/gcc-trunk/gcc/fwprop.c:603
0x1cdf1a0 forward_propagate_and_simplify
        /repo/gcc-trunk/gcc/fwprop.c:801
0x1cdf1a0 forward_propagate_into
        /repo/gcc-trunk/gcc/fwprop.c:861
0x1cdf48b forward_propagate_into
        /repo/gcc-trunk/gcc/fwprop.c:813
0x1cdf48b fwprop_insn
        /repo/gcc-trunk/gcc/fwprop.c:918
0x1cdf569 fwprop
        /repo/gcc-trunk/gcc/fwprop.c:970
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r11-6272-20201220001621-geb460c5986b-checking-yes-rtl-df-extra-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/11.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--with-cloog --with-ppl --with-isl --build=x86_64-pc-linux-gnu
--host=x86_64-pc-linux-gnu --target=x86_64-pc-linux-gnu
--with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r11-6272-20201220001621-geb460c5986b-checking-yes-rtl-df-extra-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 11.0.0 20201220 (experimental) (GCC)

[Bug target/98403] [11 Regression] ICE: in add_def, at rtl-ssa/accesses.cc:837 with -Og -march=goldmont -fPIC -fcse-follow-jumps -fipa-ra -mforce-indirect-call since r11-6188-g0b76990a9d75d97b

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98403

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[11 Regression] ICE: in     |[11 Regression] ICE: in
                   |add_def, at                 |add_def, at
                   |rtl-ssa/accesses.cc:837     |rtl-ssa/accesses.cc:837
                   |with -Og -march=goldmont    |with -Og -march=goldmont
                   |-fPIC -fcse-follow-jumps    |-fPIC -fcse-follow-jumps
                   |-fipa-ra                    |-fipa-ra
                   |-mforce-indirect-call       |-mforce-indirect-call since
                   |                            |r11-6188-g0b76990a9d75d97b
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2020-12-21
     Ever confirmed|0                           |1
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |richard.sandiford at arm dot com

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r11-6188-g0b76990a9d75d97b.

[Bug rtl-optimization/98403] [11 Regression] ICE: in add_def, at rtl-ssa/accesses.cc:837 with -Og -march=goldmont -fPIC -fcse-follow-jumps -fipa-ra -mforce-indirect-call since r11-6188-g0b76990a9d75d97b

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98403

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0
          Component|target                      |rtl-optimization

[Bug rtl-optimization/98403] [11 Regression] ICE: in add_def, at rtl-ssa/accesses.cc:837 with -Og -march=goldmont -fPIC -fcse-follow-jumps -fipa-ra -mforce-indirect-call since r11-6188-g0b76990a9d75d97b

[rsandifo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98403

rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rsandifo at gcc dot gnu.org
                 CC|                            |rsandifo at gcc dot gnu.org

[Bug rtl-optimization/98403] [11 Regression] ICE: in add_def, at rtl-ssa/accesses.cc:837 with -Og -march=goldmont -fPIC -fcse-follow-jumps -fipa-ra -mforce-indirect-call since r11-6188-g0b76990a9d75d97b

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98403

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
For the record, grub2 package is affected by the PR as well.

[Bug rtl-optimization/98403] [11 Regression] ICE: in add_def, at rtl-ssa/accesses.cc:837 with -Og -march=goldmont -fPIC -fcse-follow-jumps -fipa-ra -mforce-indirect-call since r11-6188-g0b76990a9d75d97b

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98403

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug rtl-optimization/98403] [11 Regression] ICE: in add_def, at rtl-ssa/accesses.cc:837 with -Og -march=goldmont -fPIC -fcse-follow-jumps -fipa-ra -mforce-indirect-call since r11-6188-g0b76990a9d75d97b

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98403

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Sandiford <rsandifo@gcc.gnu.org>:

https://gcc.gnu.org/g:8a25be517f8de8c060705da13db283a268cf6d12

commit r11-6459-g8a25be517f8de8c060705da13db283a268cf6d12
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Tue Jan 5 11:04:15 2021 +0000

    rtl-ssa: Fix updates to call clobbers [PR98403]

    In the PR, fwprop was changing a call instruction and tripped
    an assert when trying to update a list of call clobbers.
    There are two ways we could handle this: remove the call clobber
    and then add it back, or assume that the clobber will stay in its
    current place.

    At the moment we don't have enough information to safely move
    calls around, so the second approach seems simpler and more
    efficient.

    gcc/
            PR rtl-optimization/98403
            * rtl-ssa/changes.cc (function_info::finalize_new_accesses):
Explain
            why we don't remove call clobbers.
            (function_info::apply_changes_to_insn): Don't attempt to add
            call clobbers here.

    gcc/testsuite/
            PR rtl-optimization/98403
            * g++.dg/opt/pr98403.C: New test.

[Bug rtl-optimization/98403] [11 Regression] ICE: in add_def, at rtl-ssa/accesses.cc:837 with -Og -march=goldmont -fPIC -fcse-follow-jumps -fipa-ra -mforce-indirect-call since r11-6188-g0b76990a9d75d97b

[rsandifo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98403

rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
Fixed on trunk.