public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "sgk at troutmask dot apl.washington.edu" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/98458] PRINT the array constructed from implied do-loop throw ICE
Date: Wed, 30 Dec 2020 02:19:28 +0000	[thread overview]
Message-ID: <bug-98458-4-y7ZdTLS8gr@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98458-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98458

--- Comment #6 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Wed, Dec 30, 2020 at 12:52:03AM +0000, xiao.liu@compiler-dev.com wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98458
> 
> --- Comment #5 from xiao.liu@compiler-dev.com <xiao.liu@compiler-dev.com> ---
> (In reply to Paul Thomas from comment #4)
> > Created attachment 49856 [details]
> > Fix for the PR
> > 
> > Thank you for the report on this problem.
> > 
> > The attached patch fixes the problem and regression tests OK. I need to do a
> > bit more thinking about it because I was unable to find a point in general
> > expression simplification where the fix could be applied. Instead, it only
> > seems to work in the simplification of intrinsic functions. Fortunately,
> > this seems to be the only place where it is needed.
> > 
> > Paul
> 
> As a beginner of FORTRAN, I am not sure about the result of implied do-loop
> which contains array section, so add "print" to check. Thanks for your
> attention on this problem.
> 

PRINT has nothing to do with the problem.  I simply
have no interest in fixing the changed and now misleading
subject line.  I've been asked to stop.

My proposed patch fixes the issue in one spot.  Paul's
patch fixes potentially many spots.  Unfortunately, the
handling of implied do-loops is done in an ad hoc fashion,
and is complicated by the potential problem of exhausting
the stack.

  parent reply	other threads:[~2020-12-30  2:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-28  4:20 [Bug fortran/98458] New: implied do-loop used in initialization with RESHAPE " xiao.liu@compiler-dev.com
2020-12-28 12:03 ` [Bug fortran/98458] PRINT the array constructed from implied do-loop " anlauf at gcc dot gnu.org
2020-12-28 13:26 ` dominiq at lps dot ens.fr
2020-12-28 20:09 ` kargl at gcc dot gnu.org
2020-12-29 17:28 ` pault at gcc dot gnu.org
2020-12-30  0:52 ` xiao.liu@compiler-dev.com
2020-12-30  2:19 ` sgk at troutmask dot apl.washington.edu [this message]
2020-12-30 13:40 ` [Bug fortran/98458] ICE in gfc_conv_array_initializer due to array expressions within implied do-loop pault at gcc dot gnu.org
2020-12-30 18:12 ` sgk at troutmask dot apl.washington.edu
2021-01-05 11:39 ` pault at gcc dot gnu.org
2021-01-08 10:11 ` cvs-commit at gcc dot gnu.org
2021-05-04 12:31 ` rguenth at gcc dot gnu.org
2023-10-31 17:19 ` pault at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-98458-4-y7ZdTLS8gr@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).