[Bug c++/98471] New: libstdc++ fails to build with clang on windows because of filesystem bug

[Bug c++/98471] New: libstdc++ fails to build with clang on windows because of filesystem bug

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98471

            Bug ID: 98471
           Summary: libstdc++ fails to build with clang on windows because
                    of filesystem bug
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: unlvsur at live dot com
  Target Milestone: ---

Created attachment 49849
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49849&action=edit
working patch to fix the issue

#include<filesystem>

int main()
{

}

D:\hg\fast_io\.tmp>clang++ -o filesystem filesystem.cc -Ofast -std=c++20 -s
In file included from filesystem.cc:1:
In file included from D:\msys64\mingw64\include\c++\11.0.0\filesystem:45:
D:\msys64\mingw64\include\c++\11.0.0\bits/fs_path.h:252:15: error: invalid use
of incomplete type
      'std::filesystem::filesystem_error'
        throw filesystem_error(
              ^~~~~~~~~~~~~~~~~
D:\msys64\mingw64\include\c++\11.0.0\bits/fs_fwd.h:58:9: note: forward
declaration of
      'std::filesystem::filesystem_error'
  class filesystem_error;
        ^
In file included from filesystem.cc:1:
In file included from D:\msys64\mingw64\include\c++\11.0.0\filesystem:45:
D:\msys64\mingw64\include\c++\11.0.0\bits/fs_path.h:252:9: error: cannot throw
object of incomplete type
      'std::filesystem::filesystem_error'
        throw filesystem_error(
        ^     ~~~~~~~~~~~~~~~~~
D:\msys64\mingw64\include\c++\11.0.0\bits/fs_fwd.h:58:9: note: forward
declaration of
      'std::filesystem::filesystem_error'
  class filesystem_error;
        ^
2 errors generated.

[Bug libstdc++/98471] libstdc++ fails to build with clang on windows because of filesystem bug

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98471

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|mingw-w64-x86_64, windows   |mingw-w64-x86_64
                   |10. clang12                 |
               Host|mingw-w64-x86_64, windows   |
                   |10. clang12                 |
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2020-12-29
             Status|UNCONFIRMED                 |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org

[Bug libstdc++/98471] libstdc++ fails to build with clang on windows because of filesystem bug

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98471

--- Comment #1 from cqwrteur <unlvsur at live dot com> ---
Is this possible to fix? Is that anything wrong with the patch I provided?

[Bug libstdc++/98471] libstdc++ fails to build with clang on windows because of filesystem bug

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98471

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
The bug is already assigned to me so I get emailed about all updates to the
bug, so stop CCing my other email addresses.

Being annoying does not persuade me to fix things any faster. Quite the
opposite in fact.

I have not applied your patch because I have a better solution, and because
I've been on holiday. I'm not on holiday now, but I'm still going to wait
because you're annoying.

[Bug libstdc++/98471] libstdc++ fails to build with clang on windows because of filesystem bug

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98471

--- Comment #3 from cqwrteur <unlvsur at live dot com> ---
(In reply to Jonathan Wakely from comment #2)
> The bug is already assigned to me so I get emailed about all updates to the
> bug, so stop CCing my other email addresses.
> 
> Being annoying does not persuade me to fix things any faster. Quite the
> opposite in fact.
> 
> I have not applied your patch because I have a better solution, and because
> I've been on holiday. I'm not on holiday now, but I'm still going to wait
> because you're annoying.

okay. sorry.

[Bug libstdc++/98471] [11 Regression] libstdc++ fails to build with clang on windows because of filesystem bug

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98471

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |11.0
      Known to work|                            |10.2.1
            Summary|libstdc++ fails to build    |[11 Regression] libstdc++
                   |with clang on windows       |fails to build with clang
                   |because of filesystem bug   |on windows because of
                   |                            |filesystem bug
   Target Milestone|---                         |11.0

[Bug libstdc++/98471] [11 Regression] libstdc++ fails to build with clang on windows because of filesystem bug

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98471

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:57a4f5e4eacfbbbd0ca5f1e3f946c27d63e2b533

commit r11-6676-g57a4f5e4eacfbbbd0ca5f1e3f946c27d63e2b533
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu Jan 14 14:26:19 2021 +0000

    libstdc++: Define function to throw filesystem_error [PR 98471]

    Fix ordering problem on Windows targets where filesystem_error was used
    before being defined.

    libstdc++-v3/ChangeLog:

            PR libstdc++/98471
            * include/bits/fs_path.h (__throw_conversion_error): New
            function to throw or abort on character conversion errors.
            (__wstr_from_utf8): Move definition after filesystem_error has
            been defined. Use __throw_conversion_error.
            (path::_S_convert<_EcharT>): Use __throw_conversion_error.
            (path::_S_str_convert<_CharT, _Traits, _Allocator>): Likewise.
            (path::u8string): Likewise.

[Bug libstdc++/98471] [11 Regression] libstdc++ fails to build with clang on windows because of filesystem bug

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98471

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Should be fixed now.

[Bug libstdc++/98471] [11 Regression] libstdc++ fails to build with clang on windows because of filesystem bug

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98471

--- Comment #6 from cqwrteur <unlvsur at live dot com> ---
(In reply to Jonathan Wakely from comment #5)
> Should be fixed now.

thank you!