[Bug go/98496] New: [11 Regression] bootstrap broken in libgo on i686-gnu

[Bug go/98496] New: [11 Regression] bootstrap broken in libgo on i686-gnu

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496

            Bug ID: 98496
           Summary: [11 Regression] bootstrap broken in libgo on i686-gnu
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: go
          Assignee: ian at airs dot com
          Reporter: doko at debian dot org
                CC: cmang at google dot com
  Target Milestone: ---

seen with trunk 20210101

../../../src/libgo/go/runtime/os_gccgo.go:43:12: error: reference to undefined
name 'startupRandomData'
   43 |         if startupRandomData != nil {
      |            ^
../../../src/libgo/go/runtime/os_gccgo.go:44:30: error: reference to undefined
name 'startupRandomData'
   44 |                 n := copy(r, startupRandomData)
      |                              ^
Makefile:2962: recipe for target 'runtime.lo' failed

[Bug go/98496] [11 Regression] bootstrap broken in libgo on i686-gnu

[ian at airs dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496

Ian Lance Taylor <ian at airs dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Ian Lance Taylor <ian at airs dot com> ---
This should be fixed now.

[Bug go/98496] [11 Regression] bootstrap broken in libgo on i686-gnu

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496

Matthias Klose <doko at debian dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |---

--- Comment #2 from Matthias Klose <doko at debian dot org> ---
now fails with:

../../../src/libgo/go/crypto/x509/root_unix.go:52:17: error: reference to
undefined name 'certDirectories'
   52 |         dirs := certDirectories
      |                 ^
../../../src/libgo/go/crypto/x509/root_unix.go:61:9: error: range clause must
have array, slice, string, map, or channel type
   61 |         for _, directory := range dirs {
      |         ^
../../../src/libgo/go/crypto/x509/root_unix.go:61:13: error: invalid type for
range clause
   61 |         for _, directory := range dirs {
      |             ^
Makefile:2962: recipe for target 'crypto/x509.lo' failed
make[6]: *** [crypto/x509.lo] Error 1

[Bug go/98496] [11 Regression] bootstrap broken in libgo on i686-gnu

[svante.signell at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496

--- Comment #3 from Svante Signell <svante.signell at gmail dot com> ---
On Sat, 2021-01-02 at 17:49 +0000, doko at debian dot org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496
> 
> Matthias Klose <doko at debian dot org> changed:
> 
>            What    |Removed                     |Added
> -------------------------------------------------------------------
> ---------
>              Status|RESOLVED                    |UNCONFIRMED
>          Resolution|FIXED                       |---
> 
> --- Comment #2 from Matthias Klose <doko at debian dot org> ---
> now fails with:
> 
> ../../../src/libgo/go/crypto/x509/root_unix.go:52:17: error:
> reference to
> undefined name 'certDirectories'
>    52 |         dirs := certDirectories
>       |                 ^

I'm onto it. Patch will follow soon. A simple fix if this is the only
issue.

Thanks!

[Bug go/98496] [11 Regression] bootstrap broken in libgo on i686-gnu

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0

[Bug go/98496] [11 Regression] bootstrap broken in libgo on i686-gnu

[svante.signell at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496

--- Comment #4 from Svante Signell <svante.signell at gmail dot com> ---
Created attachment 49930
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49930&action=edit
gcc-11 patches for libgo

[Bug go/98496] [11 Regression] bootstrap broken in libgo on i686-gnu

[svante.signell at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496

--- Comment #5 from Svante Signell <svante.signell at gmail dot com> ---
Created attachment 49931
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49931&action=edit
gcc-11 patches for libgo

[Bug go/98496] [11 Regression] bootstrap broken in libgo on i686-gnu

[svante.signell at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496

--- Comment #6 from Svante Signell <svante.signell at gmail dot com> ---
Created attachment 49932
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49932&action=edit
gcc-11 patches for libgo

[Bug go/98496] [11 Regression] bootstrap broken in libgo on i686-gnu

[svante.signell at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496

--- Comment #7 from Svante Signell <svante.signell at gmail dot com> ---
Created attachment 49933
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49933&action=edit
gcc-11 patches for libgo

[Bug go/98496] [11 Regression] bootstrap broken in libgo on i686-gnu

[svante.signell at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496

--- Comment #8 from Svante Signell <svante.signell at gmail dot com> ---
Created attachment 49934
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49934&action=edit
gcc-11 patches for libgo

[Bug go/98496] [11 Regression] bootstrap broken in libgo on i686-gnu

[svante.signell at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496

--- Comment #9 from Svante Signell <svante.signell at gmail dot com> ---
Created attachment 49935
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49935&action=edit
gcc-11 patches for libgo

[Bug go/98496] [11 Regression] bootstrap broken in libgo on i686-gnu

[svante.signell at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496

--- Comment #10 from Svante Signell <svante.signell at gmail dot com> ---
Hello,

The 6 attached patches are improving the build and tests of gccgo for Hurd.
Attachment 49931 is needed for libgo to build, while the other are improving
the tests of libgo,go and gotools. Attachment 49934 if just a cosmetic change
of os_hurd.go.

Further changes are still needed to the Makefiles of libgo and gotools to
enable proper linking of libpthread and libdl. The dynamic linking of extra
libraries does not work automatically as it does on Linux systems.

Thanks!

[Bug go/98496] [11 Regression] bootstrap broken in libgo on i686-gnu

[svante.signell at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496

--- Comment #11 from Svante Signell <svante.signell at gmail dot com> ---
ping?

[Bug go/98496] [11 Regression] bootstrap broken in libgo on i686-gnu

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
patches need to be posted to gcc-patches@gcc.gnu.org

[Bug go/98496] [11 Regression] bootstrap broken in libgo on i686-gnu

[ian at airs dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496

--- Comment #13 from Ian Lance Taylor <ian at airs dot com> ---
In this case I've already sent the change out for review at
https://golang.org/cl/283692 and they should go in today (as before, this
process would go faster if you were able to send changes using Gerrit).

[Bug go/98496] [11 Regression] bootstrap broken in libgo on i686-gnu

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496

--- Comment #14 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Ian Lance Taylor <ian@gcc.gnu.org>:

https://gcc.gnu.org/g:9ac3e2feb3da89eda7a783d2c675ec897e81b338

commit r11-6678-g9ac3e2feb3da89eda7a783d2c675ec897e81b338
Author: Ian Lance Taylor <iant@golang.org>
Date:   Wed Jan 13 11:54:15 2021 -0800

    libgo: update hurd support

    Patch from Svante Signell.

    Fixes PR go/98496

    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/283692

[Bug go/98496] [11 Regression] bootstrap broken in libgo on i686-gnu

[ian at airs dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98496

Ian Lance Taylor <ian at airs dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #15 from Ian Lance Taylor <ian at airs dot com> ---
Should be fixed.