From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 7F86A385800F; Sat,  2 Jan 2021 22:22:09 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7F86A385800F
From: "slyfox at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/98499] [11 Regression] Possibly bad std::string
 initialization in constructors
Date: Sat, 02 Jan 2021 22:22:09 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: slyfox at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-98499-4-SJTXdowkmO@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-98499-4@http.gcc.gnu.org/bugzilla/>
References: <bug-98499-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Jan 2021 22:22:09 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D98499

--- Comment #1 from Sergei Trofimovich <slyfox at gcc dot gnu.org> ---
Managed to get rid of external <string> dependency:

```
struct string {
  char * _M_buf;
  // local store
  char _M_local_buf[16];

  string(const string &__str) : _M_buf(_M_local_buf) {}

  string(const char *__s) : _M_buf(_M_local_buf) {}

  ~string() {
    if (_M_buf !=3D _M_local_buf)
      __builtin_trap();
  }

  // not defined
  string();
};

// main.cc

__attribute__((noinline)) static string dir_name() { return "c"; }
__attribute__((noinline)) static string make_canonical_path(string path) {
  return path;
}
class Importer {
public:
  string imp_path;
  string ctx_path;
  string base_path;

public:
  __attribute__((noinline)) Importer(string imp_path, string ctx_path)
      : imp_path(make_canonical_path(imp_path)),
        ctx_path(make_canonical_path(ctx_path)), base_path(dir_name()) {}
};
struct Include {
  Include(const Importer &imp) {}
};
int main() { const Include &inc =3D {{"a", "b"}}; }
```

Note: all our string() constructors shoudl have `_M_buf =3D=3D _M_local_buf`
invariant. But gcc-11 generates always-crashing program:

```
; g++-11.0.0 -O2 -std=3Dc++11 -S main.cc
main:
        .cfi_startproc
        subq    $152, %rsp
        .cfi_def_cfa_offset 160
        movq    %fs:40, %rax
        movq    %rax, 136(%rsp)
        xorl    %eax, %eax
        leaq    8(%rsp), %rax
        movq    %rsp, %rsi
        leaq    32(%rsp), %rdx
        movq    %rax, (%rsp)
        leaq    64(%rsp), %rdi
        leaq    40(%rsp), %rax
        movq    %rax, 32(%rsp)
        call    _ZN8ImporterC1E6stringS0_
        ud2
```=