public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "w at 1wt dot eu" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/98503] New: [11 regression] -Warray-bounds false positive with global variables at -O2 Date: Sun, 03 Jan 2021 07:53:12 +0000 [thread overview] Message-ID: <bug-98503-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98503 Bug ID: 98503 Summary: [11 regression] -Warray-bounds false positive with global variables at -O2 Product: gcc Version: 11.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: c Assignee: unassigned at gcc dot gnu.org Reporter: w at 1wt dot eu Target Milestone: --- First, please note that I saw a handful of related reports but couldn't judge if this one might be merged with another one; if you think it can, feel free to do so! We've had build errors reported on haproxy with gcc-11 due to walking over a list whose head is in a global variable. We could simplify the reproducer to this and confirm it on godbolt.org: #include <stddef.h> struct list { struct list *n; struct list *p; }; struct list head; struct ref { struct list list; char *filename; }; struct list *first(void) { struct ref *tmp; /*tmp = (struct ref *)((char *)&head - (size_t)&((struct ref *)0)->list);*/ tmp = (struct ref *)&head; //asm("" : "+rm"(tmp)); // hide tmp's origin to shut the warning. //asm("" : "=rm"(tmp) : "0"(&head)); // discretely assign tmp from head return tmp->list.n; } Note that only the "ref->list" part is accessed here, hence it exactly matches "head" (both of type struct list). But since gcc 11 (and only this one, 1.27 to 10.2 are OK), we're getting this: <source>: In function 'first': <source>:22:19: warning: array subscript 'struct ref[0]' is partly outside array bounds of 'struct list[1]' [-Warray-bounds] 22 | return tmp->list.n; | ^~ <source>:8:13: note: while referencing 'head' 8 | struct list head; | ^~~~ Compiler returned: 0 Changing "head" to a function argument makes the warning disappear, building at -O1 as well, and obviously, cheating with the asm statement to hide "tmp" solves it (though it degrades the code quality). Removing the unused "filename" from struct "ref" removes the warning. It looks to me as if the compiler doesn't know what part of a structure is being dereferenced when we access any member, making the warning systematically bogus for embedded members accessed via container_of() and friends when the list's head is global. For now we can disable the warning, I've confirmed the generated code is correct, but since it's the first time we have a false positive on this one, I'd prefer if we can keep it as much as possible as it's one which can definitely help spot real bugs. I've just verified the version used on godbolt.org, it's "gcc version 11.0.0 20210101 (experimental) (Compiler-Explorer-Build)". I haven't rebuilt the trunk locally so it might be possible this bug got solved since as part of one of the few related ones. Thanks! Willy
next reply other threads:[~2021-01-03 7:53 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-03 7:53 w at 1wt dot eu [this message] 2021-01-03 7:56 ` [Bug c/98503] " w at 1wt dot eu 2021-01-04 12:33 ` [Bug c/98503] [11 regression] -Warray-bounds false positive with global variables at -O2 since r11-3306-g3f9a497d1b0dd9da marxin at gcc dot gnu.org 2021-01-04 16:06 ` msebor at gcc dot gnu.org 2021-01-04 16:17 ` w at 1wt dot eu 2021-01-04 16:19 ` w at 1wt dot eu 2021-01-04 17:41 ` msebor at gcc dot gnu.org 2021-01-04 22:43 ` w at 1wt dot eu 2021-01-05 11:16 ` rguenth at gcc dot gnu.org 2021-01-05 11:34 ` w at 1wt dot eu 2021-01-05 17:31 ` msebor at gcc dot gnu.org 2021-01-28 23:06 ` [Bug middle-end/98503] " msebor at gcc dot gnu.org 2021-04-27 11:40 ` [Bug middle-end/98503] [11/12 " jakub at gcc dot gnu.org 2021-05-05 16:52 ` msebor at gcc dot gnu.org 2021-05-05 17:16 ` w at 1wt dot eu 2021-07-28 7:05 ` rguenth at gcc dot gnu.org 2021-11-17 22:34 ` msebor at gcc dot gnu.org 2022-03-08 0:03 ` msebor at gcc dot gnu.org 2022-03-23 8:31 ` rguenth at gcc dot gnu.org 2022-03-23 9:32 ` w at 1wt dot eu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-98503-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).