public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "amacleod at redhat dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/98513] [10/11 Regression] Wrong code with -O3 since r10-2804-gbf05a3bbb58b3558 Date: Tue, 05 Jan 2021 15:55:24 +0000 [thread overview] Message-ID: <bug-98513-4-ZK7dTbMYsP@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-98513-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98513 --- Comment #7 from Andrew Macleod <amacleod at redhat dot com> --- This is in the legacy intersection code we have [-INF, minus_1_29(D) + 2] intersect [ -INF + 1, -INF + 2] it falls into this block: else if ((operand_less_p (vr1min, *vr0max) == 1 || operand_equal_p (vr1min, *vr0max, 0)) && operand_less_p (*vr0min, vr1min) == 1) { /* [ ( ] ) or [ ]( ) */ if (*vr0type == VR_ANTI_RANGE && vr1type == VR_ANTI_RANGE) *vr0max = vr1max; else if (*vr0type == VR_RANGE && vr1type == VR_RANGE) *vr0min = vr1min; else if (*vr0type == VR_RANGE && vr1type == VR_ANTI_RANGE) { if (TREE_CODE (vr1min) == INTEGER_CST) --> *vr0max = int_const_binop (MINUS_EXPR, vr1min, build_int_cst (TREE_TYPE (vr1min), 1)); else *vr0max = vr1min; } (gdb) p operand_less_p (vr1min, *vr0max) $19 = 1 (gdb) p operand_less_p (*vr0min, vr1min) $21 = 1 and ends up setting vr0max to (vr1min - 1), which is -INF and so returns [-INF, -INF] It seems like it *should* have entered an earlier hunk here maybe? else if ((maxeq || operand_less_p (vr1max, *vr0max) == 1) && (mineq || operand_less_p (*vr0min, vr1min) == 1)) { /* [ ( ) ] or [( ) ] or [ ( )] */ this looks like the [ ( ) ] case? if I interpret this correctly it fails to enter this block because: (gdb) p operand_less_p (vr1max, *vr0max) $22 = -2 which is operand_less_p (-INF + 2, minus_1_29(D) + 2) so it claims they cannot be compared at compile time, and thus doesn't drop into this block. Im not sure what should be done here... The easiest thing to do is simply punt when we get a -2 back anywhere... and leave vr0 as it is. thats conservative and safe. Im not even sure how best to add those checks in where needed. Otherwise we'll have to delve into why we got a -2, and eventually maybe substitute +INF for vr0max... but really, I think you'd have to do that sort of check for each of the operand_less_p() calls to be correct, and figure out when you want to substitute a +INF or -INF and recalculate the expression. Although maybe you have a more concise idea of how to handle this. Perhaps its more localized than it appears to me at first glance.
next prev parent reply other threads:[~2021-01-05 15:55 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-04 15:21 [Bug tree-optimization/98513] New: " marxin at gcc dot gnu.org 2021-01-04 15:21 ` [Bug tree-optimization/98513] " marxin at gcc dot gnu.org 2021-01-04 15:41 ` marxin at gcc dot gnu.org 2021-01-04 16:24 ` marxin at gcc dot gnu.org 2021-01-04 16:33 ` marxin at gcc dot gnu.org 2021-01-05 9:21 ` marxin at gcc dot gnu.org 2021-01-05 9:24 ` marxin at gcc dot gnu.org 2021-01-05 9:28 ` marxin at gcc dot gnu.org 2021-01-05 9:28 ` rguenth at gcc dot gnu.org 2021-01-05 15:55 ` amacleod at redhat dot com [this message] 2021-01-05 16:04 ` rguenth at gcc dot gnu.org 2021-01-05 16:40 ` rguenth at gcc dot gnu.org 2021-01-06 8:02 ` rguenth at gcc dot gnu.org 2021-01-06 8:26 ` rguenth at gcc dot gnu.org 2021-01-06 9:21 ` cvs-commit at gcc dot gnu.org 2021-01-06 9:33 ` [Bug tree-optimization/98513] [10 " marxin at gcc dot gnu.org 2021-01-12 15:23 ` cvs-commit at gcc dot gnu.org 2021-01-12 15:26 ` rguenth at gcc dot gnu.org 2021-10-06 22:34 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-98513-4-ZK7dTbMYsP@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).