From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 91E253952027; Tue, 2 Feb 2021 04:17:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 91E253952027 From: "meissner at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/98519] rs6000: @pcrel unsupported on this instruction error in pveclib Date: Tue, 02 Feb 2021 04:17:37 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Version: 11.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: meissner at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2021 04:17:37 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D98519 --- Comment #21 from Michael Meissner --- I have patches that fix the problem in the hook. My original idea of not allowing prefixed insns in the hook doesn't work because when the hook is called, it only sees pseudo registers. So what my patch does instead is to change the constraints. It makes 3 new constraints: em -- Like m, but do not allow prefixed memory eo -- Like o, but do not allow prefixed memory ep -- Only accept prefixed memory Now, 'ep' isn't needed, but I added it to give people a way to write asm us= ing prefixed instructions. If 'eo' and 'em' are ok, but we don't want to add '= ep', that is fine, it is simple to remove. The hook then goes through the constraints, and changes 'm' to 'em', and 'o= ' to 'eo'. That way old memory asm's won't see prefixed addresses. If the regi= ster allocator sees a prefixed address, it takes the address using 'pla' and substitutes a base register. In know in general, the preference is not to add new constraints, but I fee= l by adding the constraints, it makes it to be a simpler problem that writing a = new RTL pass or adding new target hooks.=