From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 41AB23858D1E; Mon,  3 Oct 2022 21:07:56 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 41AB23858D1E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1664831276;
	bh=DyVTzj9L9IjUSOu6hH8jrixL98eWpB6L0Gs2Ry4PS7Q=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=lIrvBdQj17ZDLVcQa51NCtjAqM+SpYBfwS9llGwlzJdXSC3jDbKtOgA89QtxFqEVI
	 mDu1I1qPEF61G3y1MDp3q+Gn5jBQQu+LGi7G3zs7fWZ47MM1ug1dsPF1XwA2Efv5cF
	 qHzo0CutDp6QiiYpBxNCnZL1pkZgkfZlUYzK3t6I=
From: "segher at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/98519] rs6000: @pcrel unsupported on this instruction
 error in pveclib
Date: Mon, 03 Oct 2022 21:07:55 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: segher at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: segher at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-98519-4-U9VOqAW14b@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-98519-4@http.gcc.gnu.org/bugzilla/>
References: <bug-98519-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D98519

--- Comment #28 from Segher Boessenkool <segher at gcc dot gnu.org> ---
(In reply to Peter Bergner from comment #27)
> (In reply to Michael Meissner from comment #23)
> > If we change rs6000_legitimate_address_p to return false if we have a
> > prefixed address and we are in asm, we get an insn not found error:
> >=20
> > --- /home/meissner/tmp/gcc-tmp/TskwFJ_rs6000.c  2021-02-16
> > 11:44:05.520201674 -0500
> > +++ gcc/config/rs6000/rs6000.c  2021-02-16 11:41:41.444740394 -0500
> > @@ -9532,7 +9532,7 @@ rs6000_legitimate_address_p (machine_mod
> >=20=20
> >    /* Handle prefixed addresses (PC-relative or 34-bit offset).  */
> >    if (address_is_prefixed (x, mode, NON_PREFIXED_DEFAULT))
> > -    return 1;
> > +    return !recog_data.is_asm;
> >=20=20
> >    /* Handle restricted vector d-form offsets in ISA 3.0.  */
> >    if (quad_offset_p)
>=20
> I don't think this change is correct as is, since pcrel addresses could be
> legitimate in asm

All prefixed addresses, pcrel or R=3D0, are valid always.  The original code
is correct.

But lxsd cannot use "m" as constraint anyway.  It needs "wY", and that will
work fine here?=