public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/98585] [11 Regression] target attribute resets cmodel on x86
Date: Thu, 07 Jan 2021 20:27:49 +0000	[thread overview]
Message-ID: <bug-98585-4-Kcx3RUiqvd@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98585-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98585

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 49916
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49916&action=edit
gcc11-pr98585.patch

Untested fix.  The problem is that if we have TargetSave or something without
Save attribute and use it in opts_set->x_* or global_options_set.x_* tests,
the generic code doesn't save/restore those, so either the target save/restore
options hook needs to save/restore not just the options (which it does for some
of them), but also the opts_set-> for that.  Either it can do that manually, or
by changing TargetSave to TargetVariable we can just leave to the generic code
to do it for us.

  parent reply	other threads:[~2021-01-07 20:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07 17:04 [Bug target/98585] New: " law at redhat dot com
2021-01-07 18:27 ` [Bug target/98585] " jakub at gcc dot gnu.org
2021-01-07 19:29 ` jakub at gcc dot gnu.org
2021-01-07 20:27 ` jakub at gcc dot gnu.org [this message]
2021-01-08  8:28 ` rguenth at gcc dot gnu.org
2021-01-08 11:29 ` cvs-commit at gcc dot gnu.org
2021-01-08 11:31 ` jakub at gcc dot gnu.org
2021-01-08 11:32 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-98585-4-Kcx3RUiqvd@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).