public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "bjornsundin02 at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/98611] [concepts][10/11 Regression] ICE in get_underlying_template, at cp/pt.c:6494 since r10-3735-gcb57504a55015891
Date: Wed, 13 Jan 2021 08:18:09 +0000 [thread overview]
Message-ID: <bug-98611-4-oGOl3lUWuz@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98611-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98611
--- Comment #6 from Björn Sundin <bjornsundin02 at gmail dot com> ---
(In reply to CVS Commits from comment #5)
> The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:
>
> https://gcc.gnu.org/g:e0bec6ceac47752616dd9fe0801344ed45db2fd3
>
> commit r11-6614-ge0bec6ceac47752616dd9fe0801344ed45db2fd3
> Author: Patrick Palka <ppalka@redhat.com>
> Date: Tue Jan 12 09:34:41 2021 -0500
>
> c++: Fix ICE with CTAD in concept [PR98611]
>
> This patch teaches cp_walk_subtrees to visit the template represented
> by a CTAD placeholder, which would otherwise be not visited during
> find_template_parameters. The template may be a template template
> parameter (as in the first testcase), or it may implicitly use the
> template parameters of an enclosing class template (as in the second
> testcase), and in either case we need to visit this tree to record the
> template parameters used therein for later satisfaction.
>
> gcc/cp/ChangeLog:
>
> PR c++/98611
> * tree.c (cp_walk_subtrees) <case TEMPLATE_TYPE_PARM>: Visit
> the template of a CTAD placeholder.
>
> gcc/testsuite/ChangeLog:
>
> PR c++/98611
> * g++.dg/cpp2a/concepts-ctad1.C: New test.
> * g++.dg/cpp2a/concepts-ctad2.C: New test.
Brilliant! Appreciate you :). IsInstantiationOf is a very useful generic
concept that I'd love to be able to use in my project, so I'm happy this was
fixed.
next prev parent reply other threads:[~2021-01-13 8:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 9:34 [Bug c++/98611] New: [concepts] internal compiler error: in get_underlying_template, at cp/pt.c:6494 bjornsundin02 at gmail dot com
2021-01-09 17:12 ` [Bug c++/98611] " ppalka at gcc dot gnu.org
2021-01-11 8:17 ` [Bug c++/98611] [concepts] ICE in get_underlying_template, at cp/pt.c:6494 since r10-3735-gcb57504a55015891 marxin at gcc dot gnu.org
2021-01-11 8:32 ` rguenth at gcc dot gnu.org
2021-01-11 8:37 ` [Bug c++/98611] [concepts][10/11 Regression] " marxin at gcc dot gnu.org
2021-01-12 14:35 ` cvs-commit at gcc dot gnu.org
2021-01-13 8:18 ` bjornsundin02 at gmail dot com [this message]
2021-03-31 12:33 ` [Bug c++/98611] [concepts][10 " cvs-commit at gcc dot gnu.org
2021-03-31 12:36 ` ppalka at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-98611-4-oGOl3lUWuz@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).