[Bug target/98670] New: [11 Regression] ICE in final_scan_insn_1, at final.c:3091 since r11-6628-gb668a06e37f72fd9

[Bug target/98670] New: [11 Regression] ICE in final_scan_insn_1, at final.c:3091 since r11-6628-gb668a06e37f72fd9

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98670

            Bug ID: 98670
           Summary: [11 Regression] ICE in final_scan_insn_1, at
                    final.c:3091 since r11-6628-gb668a06e37f72fd9
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org
                CC: jakub at gcc dot gnu.org
  Target Milestone: ---
              Host: x86_64-linux-gnu
            Target: x86_64-linux-gnu

Reduced from Firefox:

$ cat highbd.i
typedef short __v8hi __attribute__((__vector_size__(16)));
typedef long long __m128i __attribute__((__vector_size__(16)));
__m128i _mm_unpacklo_epi16(__m128i __A) {
  __m128i __B;
  return (__m128i)__builtin_ia32_punpcklwd128((__v8hi)__A, (__v8hi)__B);
}

void highbd_comp_avg_sse4_1();

void av1_highbd_jnt_convolve_2d_copy_sse4_1_conv_params() {
  __m128i data_0 =
              *(__attribute__((__vector_size__(2 * sizeof(long)))) long long *)
                  av1_highbd_jnt_convolve_2d_copy_sse4_1_conv_params,
          data_ref_0_lo = _mm_unpacklo_epi16(data_0);
  highbd_comp_avg_sse4_1(data_ref_0_lo);
}

$ gcc highbd.i -O2 -msse4.1 -c 
highbd.i: In function ‘av1_highbd_jnt_convolve_2d_copy_sse4_1_conv_params’:
highbd.i:16:1: error: could not split insn
   16 | }
      | ^
(insn:TI 7 17 10 2 (set (reg:V8HI 20 xmm0 [90])
        (vec_select:V8HI (vec_concat:V16HI (mem:V8HI (symbol_ref:DI
("av1_highbd_jnt_convolve_2d_copy_sse4_1_conv_params") [flags 0x3]
<function_decl 0x7ffff74f3b00
av1_highbd_jnt_convolve_2d_copy_sse4_1_conv_params>) [1 MEM[(vector(2) long
long int *)av1_highbd_jnt_convolve_2d_copy_sse4_1_conv_params]+0 S16 A16])
                (const_vector:V8HI [
                        (const_int 0 [0]) repeated x8
                    ]))
            (parallel [
                    (const_int 0 [0])
                    (const_int 8 [0x8])
                    (const_int 1 [0x1])
                    (const_int 9 [0x9])
                    (const_int 2 [0x2])
                    (const_int 10 [0xa])
                    (const_int 3 [0x3])
                    (const_int 11 [0xb])
                ]))) "highbd.i":5:19 4543 {*sse4_1_zero_extendv4hiv4si2_3}
     (nil))
during RTL pass: final
highbd.i:16:1: internal compiler error: in final_scan_insn_1, at final.c:3091
0x730e0b _fatal_insn(char const*, rtx_def const*, char const*, int, char
const*)
        /home/marxin/Programming/gcc/gcc/rtl-error.c:108
0x6c17a0 final_scan_insn_1
        /home/marxin/Programming/gcc/gcc/final.c:3091
0xb3bd2f final_scan_insn(rtx_insn*, _IO_FILE*, int, int, int*)
        /home/marxin/Programming/gcc/gcc/final.c:3170
0xb3be46 final_1
        /home/marxin/Programming/gcc/gcc/final.c:2021
0xb3ca95 rest_of_handle_final
        /home/marxin/Programming/gcc/gcc/final.c:4675
0xb3ca95 execute
        /home/marxin/Programming/gcc/gcc/final.c:4753
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug target/98670] [11 Regression] ICE in final_scan_insn_1, at final.c:3091 since r11-6628-gb668a06e37f72fd9

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98670

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |10.2.0
   Target Milestone|---                         |11.0
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
      Known to fail|                            |11.0
           Priority|P3                          |P1
   Last reconfirmed|                            |2021-01-14

[Bug target/98670] [11 Regression] ICE in final_scan_insn_1, at final.c:3091 since r11-6628-gb668a06e37f72fd9

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98670

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

[Bug target/98670] [11 Regression] ICE in final_scan_insn_1, at final.c:3091 since r11-6628-gb668a06e37f72fd9

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98670

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 49963
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49963&action=edit
gcc11-pr98670.patch

Untested fix.

[Bug target/98670] [11 Regression] ICE in final_scan_insn_1, at final.c:3091 since r11-6628-gb668a06e37f72fd9

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98670

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:0efdc7b31c2aeb3b0414a838e90014172b87302f

commit r11-6664-g0efdc7b31c2aeb3b0414a838e90014172b87302f
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Jan 14 12:55:19 2021 +0100

    i386: Fix the pmovzx SSE4.1 define_insn_and_split patterns [PR98670]

    I've made two mistakes in the *sse4_1_zero_extend* define_insn_and_split
    patterns.  One is that when it uses vector_operand, it should use Bm rather
    than m constraint, and the other one is that because it is a post-reload
    splitter it needs isa attribute to select which alternatives are valid for
    which ISAs.  Sorry for messing this up.

    2021-01-14  Jakub Jelinek  <jakub@redhat.com>

            PR target/98670
            * config/i386/sse.md (*sse4_1_zero_extendv8qiv8hi2_3,
            *sse4_1_zero_extendv4hiv4si2_3, *sse4_1_zero_extendv2siv2di2_3):
            Use Bm instead of m for non-avx.  Add isa attribute.

            * gcc.target/i386/pr98670.c: New test.

[Bug target/98670] [11 Regression] ICE in final_scan_insn_1, at final.c:3091 since r11-6628-gb668a06e37f72fd9

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98670

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.