[Bug ipa/98690] [10/11 Regression] unexpected "'removed_return.213' may be used uninitialized in this function" causes crash since r10-3311-gff6686d2e5f797d6

["cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98690

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Jambor <jamborm@gcc.gnu.org>:

https://gcc.gnu.org/g:9b8741c98f2876a430c12c85b396d29a87c9c488

commit r11-6786-g9b8741c98f2876a430c12c85b396d29a87c9c488
Author: Martin Jambor <mjambor@suse.cz>
Date:   Tue Jan 19 11:28:48 2021 +0100

    ipa-sra: Do not remove return values needed because of non-call EH

    IPA-SRA already contains a check to figure out that an otherwise dead
    parameter is actually required because of non-call exceptions, but it
    is not present at the equivalent spot where SRA figures out whether
    the return statement is used for anything useful.  This patch adds
    that condition there.

    Unfortunately, even though this patch should be good enough for any
    normal (I'd even say reasonable) use of the compiler, it hints that
    when the user manually switches all sorts of DCE, IPA-SRA would
    probably leave behind problematic statements manipulating what
    originally were return values, just like it does for parameters (PR
    93385).  Fixing this properly might unfortunately be a separate issue
    from the mentioned bug because the LHS of a call is changed during
    call redirection and the caller often is not a clone.  But I'll see
    what I can do.

    Meanwhile, the patch below has been bootstrapped and tested on x86_64.

    gcc/ChangeLog:

    2021-01-18  Martin Jambor  <mjambor@suse.cz>

            PR ipa/98690
            * ipa-sra.c (ssa_name_only_returned_p): New parameter fun.  Check
            whether non-call exceptions allow removal of a statement.
            (isra_analyze_call): Pass the appropriate function to
            ssa_name_only_returned_p.

    gcc/testsuite/ChangeLog:

    2021-01-18  Martin Jambor  <mjambor@suse.cz>

            PR ipa/98690
            * g++.dg/ipa/pr98690.C: New test.