public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "m.krause@tu-harburg.de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/98704] coroutine_handle::done() == false after promise's unhandled_exception() has thrown
Date: Sun, 17 Jan 2021 13:29:21 +0000	[thread overview]
Message-ID: <bug-98704-4-ZlVTwidYod@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98704-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98704

--- Comment #1 from Michael Krause <m.krause@tu-harburg.de> ---
Created attachment 49985
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=49985&action=edit
A possible fix?

Would this be the proper way to fix the problem? That is, instead of generating
a simple "promise.unhandled_exception()" call, generate:

         try {
             promise.unhandled_exception();
         } catch(...) {
             resume_fn_ptr = 0; // ensure that done() returns true
             throw;
         }

Seems to fix my problem, but then I don't know the gcc code base; maybe the
change has undesired side effects. If somebody can confirm this is the way to
go, I would be willing to provide a cleaned-up, mergable version including test
cases etc...

  reply	other threads:[~2021-01-17 13:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-16  8:30 [Bug c++/98704] New: " m.krause@tu-harburg.de
2021-01-17 13:29 ` m.krause@tu-harburg.de [this message]
2021-03-12 15:28 ` [Bug c++/98704] " iains at gcc dot gnu.org
2021-03-15 15:56 ` cvs-commit at gcc dot gnu.org
2021-03-22 22:04 ` cvs-commit at gcc dot gnu.org
2021-03-24 12:40 ` iains at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-98704-4-ZlVTwidYod@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).