From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 20E0F3861896; Thu, 21 Jan 2021 13:12:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20E0F3861896 From: "jakub at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug libgomp/98738] task-detach-6.f90 hangs intermittently Date: Thu, 21 Jan 2021 13:12:29 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: libgomp X-Bugzilla-Version: 11.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: jakub at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 11.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jan 2021 13:12:30 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D98738 --- Comment #10 from Jakub Jelinek --- I've been wondering whether it wouldn't be best to pass through omp_eventhandle_t the pointer to the gomp_task rather than some particular semaphore and in omp_fulfill_event then decide based on that task, one case would be if it is the included task, then it should post a semaphore and be done with it, otherwise (not included task), it should find the correspondi= ng team (which might not be necessary the omp_fulfill_event's task), lock the task_lock and figure out in which of the many cases the task is in, if not = yet finished, perhaps just clear detach bool and be done with it, if in the sta= te after that, figure out what is waiting for that task and deal with that. Not sure if a per-task semaphore is what we want in that case, e.g. we could have a taskwait, taskgroup end or barrier waiting for multiple tasks with detach clause and if that is the only thing they might be waiting on, then those should be sleeping on taskwait_sem, taskgroup_sem or on the barrier, = so depending on what they are sleeping on that should be awaken.=