From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 836EC385480F; Wed, 20 Jan 2021 16:06:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 836EC385480F From: "jakub at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug libgomp/98738] task-detach-6.f90 hangs intermittently Date: Wed, 20 Jan 2021 16:06:06 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: libgomp X-Bugzilla-Version: 11.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: jakub at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 11.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2021 16:06:06 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D98738 --- Comment #8 from Jakub Jelinek --- I think omp_fullfill_event needs to do much more than it does. Just look e.g. at what gomp_target_task_completion does. The function need= s to find out in what state the task is (I'm afraid it needs to take the team->task_lock around that checking (if any)), if the task hasn't finished yet, it shouldn't need anything but sem_post but if it has already finished= and it is just waiting for the completion event, it needs to handle taskwait, depend wait, taskgroup waits and barrier waits. Sorry for not catching that during patch review.=