From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id A4A773A77046; Fri, 23 Apr 2021 12:47:20 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A4A773A77046
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/98767] Function signature lost in concept diagnostic message
Date: Fri, 23 Apr 2021 12:47:20 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ppalka at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-98767-4-Ta90Cd8nx1@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-98767-4@http.gcc.gnu.org/bugzilla/>
References: <bug-98767-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Apr 2021 12:47:20 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D98767

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:87fc34a461cf362947a430d8a241f653fd83bc7b

commit r12-86-g87fc34a461cf362947a430d8a241f653fd83bc7b
Author: Patrick Palka <ppalka@redhat.com>
Date:   Fri Apr 23 08:47:02 2021 -0400

    c++: Fix pretty printing pointer to function type [PR98767]

    When pretty printing a pointer to function type,
    pp_cxx_parameter_declaration_clause ends up always outputting an empty
    function parameter list because the loop that outputs the list iterates
    over 'args' instead of 'types', and 'args' is empty when a FUNCTION_TYPE
    is passed to this routine (as opposed to a FUNCTION_DECL).

    This patch fixes this by making the loop iterate over 'types' instead.
    This patch also moves the retrofitted chain-of-PARM_DECLs printing from
    here to pp_cxx_requires_expr, the only caller that uses it.  Doing so
    lets us easily output the trailing '...' in the parameter list of a
    variadic function, which this patch also implements.

    gcc/cp/ChangeLog:

            PR c++/98767
            * cxx-pretty-print.c (pp_cxx_parameter_declaration_clause):
            Adjust parameter list loop to iterate over 'types' instead of
            'args'.  Output the trailing '...' for a variadic function.
            Remove PARM_DECL support.
            (pp_cxx_requires_expr): Pretty print the parameter list directly
            instead of going through pp_cxx_parameter_declaration_clause.

    gcc/testsuite/ChangeLog:

            PR c++/98767
            * g++.dg/concepts/diagnostic17.C: New test.=