public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/98867] Failure to use SRI instruction for shift-right-and-insert vector operations
Date: Thu, 04 Feb 2021 07:10:07 +0000	[thread overview]
Message-ID: <bug-98867-4-ohIY8fn07O@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98867-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98867

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-02-04
           Severity|normal                      |enhancement
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
>This may be a bit too complex for combine to match though
I don't think so really:

Trying 18, 13 -> 19:
   18: r110:V16QI=r111:V16QI&r112:V16QI
      REG_DEAD r111:V16QI
      REG_EQUAL r111:V16QI&const_vector
   13: r106:V16QI=r107:V16QI 0>>const_vector
      REG_DEAD r107:V16QI
   19: r113:V16QI=r106:V16QI|r110:V16QI
      REG_DEAD r110:V16QI
      REG_DEAD r106:V16QI
Failed to match this instruction:
(set (reg:V16QI 113 [ vect__6.15 ])
    (ior:V16QI (and:V16QI (reg:V16QI 111 [ MEM[symbol: out, index: ivtmp.22_30,
offset: 0B] ])
            (reg:V16QI 112))
        (lshiftrt:V16QI (reg:V16QI 107 [ MEM[symbol: in, index: ivtmp.22_30,
offset: 0B] ])
            (const_vector:V16QI [
                    (const_int 6 [0x6]) repeated x16
                ]))))


The only problem is (reg:V16QI 112) was not replaced with const_vector, that it
was formed from.
But insn 18 does have this REG_EQUAL:
        (expr_list:REG_EQUAL (and:V16QI (reg:V16QI 111 [ MEM[symbol: out,
index: ivtmp.22_30, offset: 0B] ])
                (const_vector:V16QI [
                        (const_int -4 [0xfffffffffffffffc]) repeated x16
                    ]))

So it might be easy to match, just combine is not showing all of what is being
tried?
So maybe adding a pattern for it might be easy ....

      reply	other threads:[~2021-02-04  7:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28 15:02 [Bug target/98867] New: " ktkachov at gcc dot gnu.org
2021-02-04  7:10 ` pinskia at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-98867-4-ohIY8fn07O@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).