public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "wilson at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/98892] FAIL: gcc.dg/plugin/diagnostic-test-expressions-1.c
Date: Sat, 26 Jun 2021 14:46:36 +0000	[thread overview]
Message-ID: <bug-98892-4-YIBLQlMH5o@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98892-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98892

--- Comment #3 from Jim Wilson <wilson at gcc dot gnu.org> ---
On second thought, I don't think that there is anything wrong with
dg-*-multiline-output.

The problem is simply that the diagnostic code is left shifting the error
message by m_x_offset_display, and this left shit causes the printed message to
not match the expected message.  The difference is only a few chars of white
space which makes it very hard to see the problem when inspecting the test log.
 You have to count white space characters to see the problem.  In my case,
there is one less space char in the printed message than in the expected
message.

And it looks like the solution is -fmessage-length=0 which is already added to
ALWAYS_CXXFLAGS and should maybe be added to ALWAYS_TEST_FLAGS instead.  Or
maybe just added to this one testcase for now to make it work.

  parent reply	other threads:[~2021-06-26 14:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-29 16:44 [Bug c/98892] New: " danglin at gcc dot gnu.org
2021-06-03 11:19 ` [Bug c/98892] " ebotcazou at gcc dot gnu.org
2021-06-26  4:09 ` wilson at gcc dot gnu.org
2021-06-26 14:46 ` wilson at gcc dot gnu.org [this message]
2021-06-28 17:27 ` wilson at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-98892-4-YIBLQlMH5o@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).