From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 6A13E398C815; Wed,  3 Feb 2021 03:59:35 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6A13E398C815
From: "luoxhu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/98914] [11 Regression] ICE in rs6000_expand_vector_set,
 at config/rs6000/rs6000.c:7198
Date: Wed, 03 Feb 2021 03:59:34 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: luoxhu at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: luoxhu at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 11.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-98914-4-A5DbAk6FX5@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-98914-4@http.gcc.gnu.org/bugzilla/>
References: <bug-98914-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Feb 2021 03:59:35 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D98914

--- Comment #1 from luoxhu at gcc dot gnu.org ---
The type of k in the case should be "long" to reproduce the issue,=20

ICE happens at=20

rs6000_expand_vector_set:  gcc_assert (GET_MODE (idx) =3D=3D E_SImode);


Reason is the vector index variable need be "signed int" for all vec_insert
prototype.=20


ELFv2 ABI:
vector signed char vec_insert (signed char, vector signed char, signed int);
vector unsigned char vec_insert (unsigned char, vector unsigned char, signed
int);
vector signed int vec_insert (signed int, vector signed int, signed int);
vector unsigned int vec_insert (unsigned int, vector unsigned int, signed i=
nt);
vector signed long long vec_insert (signed long long, vector signed long lo=
ng,
signed int);


Not sure all targets like X86/AArch64 also has some requirements, and wheth=
er
below fix reasonable to not generate IFN VEC_SET for stmt like=20

VIEW_CONVERT_EXPR<unsigned char[16]>(v)[k_7] =3D 170;  ?


diff --git a/gcc/gimple-isel.cc b/gcc/gimple-isel.cc
index 2c78a08d3f1..dbbae270a36 100644
--- a/gcc/gimple-isel.cc
+++ b/gcc/gimple-isel.cc
@@ -77,6 +77,7 @@ gimple_expand_vec_set_expr (gimple_stmt_iterator *gsi)
       tree view_op0 =3D TREE_OPERAND (op0, 0);
       machine_mode outermode =3D TYPE_MODE (TREE_TYPE (view_op0));
       if (auto_var_in_fn_p (view_op0, cfun->decl)
+         && TYPE_MODE (TREE_TYPE (pos)) =3D=3D E_SImode
          && !TREE_ADDRESSABLE (view_op0) && can_vec_set_var_idx_p (outermo=
de))
        {
          location_t loc =3D gimple_location (stmt);=