From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id DAA1139F14B5; Fri, 5 Feb 2021 12:39:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DAA1139F14B5 From: "marxin at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug sanitizer/98920] [10/11 Regression] uses regexec without support for REG_STARTEND with -fsanitize=address Date: Fri, 05 Feb 2021 12:39:21 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: sanitizer X-Bugzilla-Version: 10.2.1 X-Bugzilla-Keywords: wrong-code X-Bugzilla-Severity: normal X-Bugzilla-Who: marxin at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: marxin at gcc dot gnu.org X-Bugzilla-Target-Milestone: 10.3 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Feb 2021 12:39:22 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D98920 --- Comment #5 from Martin Li=C5=A1ka --- (In reply to Jakub Jelinek from comment #3) > I'm not sure if your patch is correct. > glibc has the system of earliest symbol versions, and so on certain > architectures > GLIBC_2.3.4 symver will not appear at all. > Given: > ./sysdeps/mach/hurd/shlib-versions:DEFAULT GLIBC_2.2.6 > ./sysdeps/unix/sysv/linux/csky/shlib-versions:DEFAULT GLIBC_2.29 > ./sysdeps/unix/sysv/linux/microblaze/shlib-versions:DEFAULT GLIBC_2.18 > ./sysdeps/unix/sysv/linux/arc/shlib-versions:DEFAULT=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20 > GLIBC_2.32 > ./sysdeps/unix/sysv/linux/m68k/coldfire/shlib-versions:DEFAULT=20=20=20= =20=20=20=20=20=20=20=20=20=20=20 > GLIBC_2.4 > ./sysdeps/unix/sysv/linux/arm/shlib-versions:DEFAULT GLIBC_2.4 > ./sysdeps/unix/sysv/linux/s390/s390-64/shlib-versions:DEFAULT GLIBC_2.2 > ./sysdeps/unix/sysv/linux/riscv/shlib-versions:DEFAULT GLIBC_2.27 > ./sysdeps/unix/sysv/linux/riscv/shlib-versions:DEFAULT GLIBC_2.27 > ./sysdeps/unix/sysv/linux/riscv/shlib-versions:DEFAULT GLIBC_2.33 > ./sysdeps/unix/sysv/linux/riscv/shlib-versions:DEFAULT GLIBC_2.33 > ./sysdeps/unix/sysv/linux/x86_64/x32/shlib-versions:# DEFAULT Earliest > symbol set > ./sysdeps/unix/sysv/linux/x86_64/x32/shlib-versions:DEFAULT GLIBC_2.16 > ./sysdeps/unix/sysv/linux/x86_64/64/shlib-versions:# DEFAULT Earliest > symbol set > ./sysdeps/unix/sysv/linux/x86_64/64/shlib-versions:DEFAULT GLIBC_2.2.5 > ./sysdeps/unix/sysv/linux/powerpc/powerpc64/shlib-versions:DEFAULT=09=09 > GLIBC_2.17 > ./sysdeps/unix/sysv/linux/powerpc/powerpc64/shlib-versions:DEFAULT=09=09 > GLIBC_2.3 > ./sysdeps/unix/sysv/linux/nios2/shlib-versions:DEFAULT=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20 > GLIBC_2.21 > ./sysdeps/unix/sysv/linux/aarch64/shlib-versions:DEFAULT GLIBC_2.17 > and the limited list of arches supported by libsanitizer, I'd say at least > riscv*, powerpc64le and aarch64 (and maybe x86-64 -mx32 if supported) are > affected. Thank you for this. You are right, my patch is not correct. So for the arch= s we care about we should do: x86_64 - require GLIBC_2.3.4 ppc64 - require GLIBC_2.3.4 aarch64, ppc64le, x32 and riscv* are newer than 2.3.4, so a default non-versioned symbol should be fine. Am I right?=