From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id E6D573AA981D; Tue, 20 Apr 2021 23:32:22 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E6D573AA981D
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/99033] [9 Regression] ICE in tree_to_poly_int64, at
 tree.c:3091
Date: Tue, 20 Apr 2021 23:32:22 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 9.4
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-99033-4-orKQ8QPj9E@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-99033-4@http.gcc.gnu.org/bugzilla/>
References: <bug-99033-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2021 23:32:23 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99033

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:d1eaf74ee3ac503576e2830e77505cce1ee56e8d

commit r9-9419-gd1eaf74ee3ac503576e2830e77505cce1ee56e8d
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Feb 11 17:24:17 2021 +0100

    c++: Fix zero initialization of flexible array members [PR99033]

    array_type_nelts returns error_mark_node for type of flexible array mem=
bers
    and build_zero_init_1 was placing an error_mark_node into the CONSTRUCT=
OR,
    on which e.g. varasm ICEs.  I think there is nothing erroneous on zero
    initialization of flexible array members though, such arrays should sim=
ply
    get no elements, like they do if such classes are constructed (everythi=
ng
    except when some larger initializer comes from an explicit initializer).

    So, this patch handles [] arrays in zero initialization like [0] arrays
    and fixes handling of the [0] arrays - the
    tree_int_cst_equal (max_index, integer_minus_one_node) check
    didn't do what it thought it would do, max_index is typically unsigned
    integer (sizetype) and so it is never equal to a -1.

    What the patch doesn't do and maybe would be desirable is if it returns
    error_mark_node for other reasons let the recursive callers not stick t=
hat
    into CONSTRUCTOR but return error_mark_node instead.  But I don't have a
    testcase where that would be needed right now.

    2021-02-11  Jakub Jelinek  <jakub@redhat.com>

            PR c++/99033
            * init.c (build_zero_init_1): Handle zero initialiation of
            flexible array members like initialization of [0] arrays.
            Use integer_minus_onep instead of comparison to
integer_minus_one_node
            and integer_zerop instead of comparison against size_zero_node.
            Formatting fixes.

            * g++.dg/ext/flexary38.C: New test.

    (cherry picked from commit ea535f59b19f65e5b313c990ee6c194a7b055bd7)=