From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 9C8EF3861013; Wed, 10 Feb 2021 20:51:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9C8EF3861013 From: "bergner at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/99041] combine creates invalid address which ICEs in decompose_normal_address Date: Wed, 10 Feb 2021 20:51:10 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Version: 11.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: bergner at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: bergner at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2021 20:51:10 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99041 Peter Bergner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #6 from Peter Bergner --- (In reply to Peter Bergner from comment #3) > Ahh, ok. I can make that more robust. Thanks for the pointer! The mma_assemble_pair/mma_assemble_acc patterns both generate lxv or lxvp instructions, which both use a DQ offset and we already have function to te= st for that. The following change fixes the ICE, so I'll give it a spin on regtesting. diff --git a/gcc/config/rs6000/predicates.md b/gcc/config/rs6000/predicates= .md index 76328ecff3d..bd26c62b3a4 100644 --- a/gcc/config/rs6000/predicates.md +++ b/gcc/config/rs6000/predicates.md @@ -1156,7 +1156,9 @@ ;; Return 1 if this operand is valid for a MMA assemble accumulator insn. (define_special_predicate "mma_assemble_input_operand" (match_test "(mode =3D=3D V16QImode - && (vsx_register_operand (op, mode) || MEM_P (op)))")) + && (vsx_register_operand (op, mode) + || (MEM_P (op) + && quad_address_p (XEXP (op, 0), mode, false))))")) ;; Return 1 if this operand is valid for an MMA disassemble insn. (define_predicate "mma_disassemble_output_operand"=