From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 296D93858002; Mon, 29 Mar 2021 12:38:24 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 296D93858002
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/99062] [10 Regression] ICE in tree_to_uhwi, at tree.h:4579
Date: Mon, 29 Mar 2021 12:38:23 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: mpolacek at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 10.3
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-99062-4-VixHh6pIZh@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-99062-4@http.gcc.gnu.org/bugzilla/>
References: <bug-99062-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Mar 2021 12:38:24 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99062

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:9d020d111fbeae228b20d75a8c832b214e561ab3

commit r10-9553-g9d020d111fbeae228b20d75a8c832b214e561ab3
Author: Marek Polacek <polacek@redhat.com>
Date:   Wed Feb 10 15:24:25 2021 -0500

    c-family: ICE with assume_aligned attribute [PR99062]

    We ICE in handle_assume_aligned_attribute since r271338 which added

    @@ -2935,8 +2936,8 @@ handle_assume_aligned_attribute (tree *node, tree
name, tree args, int,
              /* The misalignment specified by the second argument
                 must be non-negative and less than the alignment.  */
              warning (OPT_Wattributes,
    -                  "%qE attribute argument %E is not in the range [0, %=
E)",
    -                  name, val, align);
    +                  "%qE attribute argument %E is not in the range [0,
%wu]",
    +                  name, val, tree_to_uhwi (align) - 1);
              *no_add_attrs =3D true;
              return NULL_TREE;
            }
    because align is INT_MIN and tree_to_uhwi asserts tree_fits_uhwi_p -- w=
hich
    ALIGN does not and the prior tree_fits_shwi_p check is fine with it, as
    well as the integer_pow2p check.

    Since neither of the arguments to assume_aligned can be negative, I've
    hoisted the tree_int_cst_sgn check.  And add the missing "argument"
    word to an existing warning.

    gcc/c-family/ChangeLog:

            PR c++/99062
            * c-attribs.c (handle_assume_aligned_attribute): Check that the
            alignment argument is non-negative.  Tweak a warning message.

    gcc/testsuite/ChangeLog:

            PR c++/99062
            * gcc.dg/attr-assume_aligned-4.c: Adjust dg-warning.
            * g++.dg/ext/attr-assume-aligned.C: New test.

    (cherry picked from commit 30a4d95bf76b0a0fdb66ac0211589a4434c83af3)=