From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 105633850423; Wed, 10 Feb 2021 21:05:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 105633850423 From: "mpolacek at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/99062] [10/11 Regression] ICE in tree_to_uhwi, at tree.h:4579 Date: Wed, 10 Feb 2021 21:05:49 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: c++ X-Bugzilla-Version: 11.0 X-Bugzilla-Keywords: ice-on-valid-code X-Bugzilla-Severity: normal X-Bugzilla-Who: mpolacek at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: mpolacek at gcc dot gnu.org X-Bugzilla-Target-Milestone: 10.3 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2021 21:05:50 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99062 --- Comment #5 from Marek Polacek --- (In reply to Martin Sebor from comment #4) > There already is a test in the attribute handler to validate the alignmen= t: > it calls integer_pow2p (val). Val here is: > > constant -2147483648> > but integer_pow2p (val) returns true. I'd expect the function to return > false since INT_MIN is not a power of two. Anyway, the test integer_pow2p > (val) should probably be changed to tree_int_cst_sgn (val) < 0 || > integer_pow2p (val). About to post a patch that hoists the tree_int_cst_sgn check so that we don= 't have to repeat it.=