public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c++/99080] New: Add !TYPE_P assert to type_dependent_expression_p
@ 2021-02-12 18:22 mpolacek at gcc dot gnu.org
2021-02-12 18:22 ` [Bug c++/99080] " mpolacek at gcc dot gnu.org
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2021-02-12 18:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99080
Bug ID: 99080
Summary: Add !TYPE_P assert to type_dependent_expression_p
Product: gcc
Version: 11.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c++
Assignee: unassigned at gcc dot gnu.org
Reporter: mpolacek at gcc dot gnu.org
Target Milestone: ---
As discussed here
<https://gcc.gnu.org/pipermail/gcc-patches/2021-February/564629.html>,
type_dependent_expression_p should not be called with a type argument. An
assert would help shake out such cases.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug c++/99080] Add !TYPE_P assert to type_dependent_expression_p
2021-02-12 18:22 [Bug c++/99080] New: Add !TYPE_P assert to type_dependent_expression_p mpolacek at gcc dot gnu.org
@ 2021-02-12 18:22 ` mpolacek at gcc dot gnu.org
2022-05-30 21:17 ` cvs-commit at gcc dot gnu.org
2022-05-30 21:19 ` mpolacek at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2021-02-12 18:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99080
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Keywords| |internal-improvement
Ever confirmed|0 |1
Last reconfirmed| |2021-02-12
Assignee|unassigned at gcc dot gnu.org |mpolacek at gcc dot gnu.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug c++/99080] Add !TYPE_P assert to type_dependent_expression_p
2021-02-12 18:22 [Bug c++/99080] New: Add !TYPE_P assert to type_dependent_expression_p mpolacek at gcc dot gnu.org
2021-02-12 18:22 ` [Bug c++/99080] " mpolacek at gcc dot gnu.org
@ 2022-05-30 21:17 ` cvs-commit at gcc dot gnu.org
2022-05-30 21:19 ` mpolacek at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-05-30 21:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99080
--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>:
https://gcc.gnu.org/g:ff91735a5b861dd6eaf2c1e511f26a9255898e7d
commit r13-860-gff91735a5b861dd6eaf2c1e511f26a9255898e7d
Author: Marek Polacek <polacek@redhat.com>
Date: Fri May 13 20:09:53 2022 -0400
c++: Add !TYPE_P assert to type_dependent_expression_p [PR99080]
As discussed here:
<https://gcc.gnu.org/pipermail/gcc-patches/2021-February/564629.html>,
type_dependent_expression_p should not be called with a type argument.
I promised I'd add an assert so here it is. One place needed adjusting.
PR c++/99080
gcc/cp/ChangeLog:
* pt.cc (type_dependent_expression_p): Assert !TYPE_P.
* semantics.cc (finish_id_expression_1): Handle
UNBOUND_CLASS_TEMPLATE
specifically.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug c++/99080] Add !TYPE_P assert to type_dependent_expression_p
2021-02-12 18:22 [Bug c++/99080] New: Add !TYPE_P assert to type_dependent_expression_p mpolacek at gcc dot gnu.org
2021-02-12 18:22 ` [Bug c++/99080] " mpolacek at gcc dot gnu.org
2022-05-30 21:17 ` cvs-commit at gcc dot gnu.org
@ 2022-05-30 21:19 ` mpolacek at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2022-05-30 21:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99080
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Done.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-30 21:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-12 18:22 [Bug c++/99080] New: Add !TYPE_P assert to type_dependent_expression_p mpolacek at gcc dot gnu.org
2021-02-12 18:22 ` [Bug c++/99080] " mpolacek at gcc dot gnu.org
2022-05-30 21:17 ` cvs-commit at gcc dot gnu.org
2022-05-30 21:19 ` mpolacek at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).