[Bug c/99121] New: [9/10/11 Regression] ICE tree check: expected integer_cst, have var_decl in get_len, at tree.h:6037

[Bug c/99121] New: [9/10/11 Regression] ICE tree check: expected integer_cst, have var_decl in get_len, at tree.h:6037

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99121

            Bug ID: 99121
           Summary: [9/10/11 Regression] ICE tree check: expected
                    integer_cst, have var_decl in get_len, at tree.h:6037
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Changed between 20180708 and 20180722 at -O2+ :


$ cat z1.c
void f (int);
void g (int n)
{
  int a[n][0];
  f (((int *) a)[0]);
}


$ gcc-9-20180708  -c z1.c -Wall -O2
$ gcc-11-20210214 -c z1.c -Wall -O1
$
$ gcc-11-20210214 -c z1.c -Wall -O2
during GIMPLE pass: vrp
z1.c: In function 'g':
z1.c:2:6: internal compiler error: tree check: expected integer_cst, have
var_decl in get_len, at tree.h:6037
    2 | void g (int n)
      |      ^
0x6305f8 tree_check_failed(tree_node const*, char const*, int, char const*,
...)
        ../../gcc/tree.c:9814
0xa1a34d tree_check(tree_node const*, char const*, int, char const*, tree_code)
        ../../gcc/tree.h:3605
0xa1a34d wi::extended_tree<128>::get_len() const
        ../../gcc/tree.h:6037
0xa1a34d wi::int_traits<generic_wide_int<wi::extended_tree<128> >
>::decompose(long*, unsigned int, generic_wide_int<wi::extended_tree<128> >
const&)
        ../../gcc/wide-int.h:985
0xa1a34d wide_int_ref_storage<true,
false>::wide_int_ref_storage<generic_wide_int<wi::extended_tree<128> >
>(generic_wide_int<wi::extended_tree<128> > const&, unsigned int)
        ../../gcc/wide-int.h:1034
0xa1a34d generic_wide_int<wide_int_ref_storage<true, false>
>::generic_wide_int<generic_wide_int<wi::extended_tree<128> >
>(generic_wide_int<wi::extended_tree<128> > const&, unsigned int)
        ../../gcc/wide-int.h:790
0xa1a34d wi::binary_traits<generic_wide_int<wi::extended_tree<128> >,
generic_wide_int<wi::extended_tree<128> >,
wi::int_traits<generic_wide_int<wi::extended_tree<128> > >::precision_type,
wi::int_traits<generic_wide_int<wi::extended_tree<128> >
>::precision_type>::result_type wi::sub<generic_wide_int<wi::extended_tree<128>
>, generic_wide_int<wi::extended_tree<128> >
>(generic_wide_int<wi::extended_tree<128> > const&,
generic_wide_int<wi::extended_tree<128> > const&)
        ../../gcc/wide-int.h:2512
0x17b934c wi::binary_traits<generic_wide_int<wi::extended_tree<128> >,
generic_wide_int<wi::extended_tree<128> >,
wi::int_traits<generic_wide_int<wi::extended_tree<128> > >::precision_type,
wi::int_traits<generic_wide_int<wi::extended_tree<128> >
>::precision_type>::operator_result
operator-<generic_wide_int<wi::extended_tree<128> >,
generic_wide_int<wi::extended_tree<128> >
>(generic_wide_int<wi::extended_tree<128> > const&,
generic_wide_int<wi::extended_tree<128> > const&)
        ../../gcc/wide-int.h:3297
0x17b934c array_bounds_checker::check_mem_ref(unsigned int, tree_node*, bool)
        ../../gcc/gimple-array-bounds.cc:620
0x17b9c19 array_bounds_checker::check_array_bounds(tree_node**, int*, void*)
        ../../gcc/gimple-array-bounds.cc:909
0x109bde3 walk_tree_1(tree_node**, tree_node* (*)(tree_node**, int*, void*),
void*, hash_set<tree_node*, false, default_hash_traits<tree_node*> >*,
tree_node* (*)(tree_node**, int*, tree_node* (*)(tree_node**, int*, void*),
void*, hash_set<tree_node*, false, default_hash_traits<tree_node*> >*))
        ../../gcc/tree.c:12099
0xa2bff3 walk_gimple_op(gimple*, tree_node* (*)(tree_node**, int*, void*),
walk_stmt_info*)
        ../../gcc/gimple-walk.c:202
0x17b5201 check_array_bounds_dom_walker::before_dom_children(basic_block_def*)
        ../../gcc/gimple-array-bounds.cc:966
0x179f077 dom_walker::walk(basic_block_def*)
        ../../gcc/domwalk.c:309
0x17b721a array_bounds_checker::check()
        ../../gcc/gimple-array-bounds.cc:980
0x1069181 execute_vrp
        ../../gcc/tree-vrp.c:4517

[Bug c/99121] [9/10/11 Regression] ICE tree check: expected integer_cst, have var_decl in get_len, at tree.h:6037

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99121

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-02-16
   Target Milestone|---                         |9.4
           Priority|P3                          |P2
     Ever confirmed|0                           |1
                 CC|                            |jakub at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r9-1948-gd893b683f40884cd00b5beb392566ecc7b67f721

[Bug c/99121] [9/10/11 Regression] ICE tree check: expected integer_cst, have var_decl in get_len, at tree.h:6037

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99121

Martin Sebor <msebor at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |msebor at gcc dot gnu.org
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |msebor at gcc dot gnu.org
      Known to fail|                            |10.2.0, 11.0, 9.2.0

[Bug tree-optimization/99121] [9/10/11 Regression] ICE tree check: expected integer_cst, have var_decl in get_len, at tree.h:6037

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99121

Martin Sebor <msebor at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |56456

--- Comment #2 from Martin Sebor <msebor at gcc dot gnu.org> ---
Another slightly different ICE in the same code:

$ cat t.c && gcc -O2 -Wall t.c
void f (void*);

int g (int n)
{
  int a[0][n];

  f (a);

  return ((int*) a)[0];
}

during GIMPLE pass: vrp
t.c: In function ‘g’:
t.c:3:5: internal compiler error: tree check: expected integer_cst, have
var_decl in get_len, at tree.h:5947
    3 | int g (int n)
      |     ^
0x1777567 tree_check_failed(tree_node const*, char const*, int, char const*,
...)
        /ssd/src/gcc/10-branch/gcc/tree.c:9730
0x8d48d7 tree_check(tree_node const*, char const*, int, char const*, tree_code)
        /ssd/src/gcc/10-branch/gcc/tree.h:3550
0xaa24bf wi::extended_tree<128>::get_len() const
        /ssd/src/gcc/10-branch/gcc/tree.h:5947
0xaa20fc wi::int_traits<generic_wide_int<wi::extended_tree<128> >
>::decompose(long*, unsigned int, generic_wide_int<wi::extended_tree<128> >
const&)
        /ssd/src/gcc/10-branch/gcc/wide-int.h:985
0xaa1a32 wide_int_ref_storage<true,
false>::wide_int_ref_storage<generic_wide_int<wi::extended_tree<128> >
>(generic_wide_int<wi::extended_tree<128> > const&, unsigned int)
        /ssd/src/gcc/10-branch/gcc/wide-int.h:1034
0xaa0a1a generic_wide_int<wide_int_ref_storage<true, false>
>::generic_wide_int<generic_wide_int<wi::extended_tree<128> >
>(generic_wide_int<wi::extended_tree<128> > const&, unsigned int)
        /ssd/src/gcc/10-branch/gcc/wide-int.h:790
0xafc231
fixed_wide_int_storage<128>::fixed_wide_int_storage<generic_wide_int<wi::extended_tree<128>
> >(generic_wide_int<wi::extended_tree<128> > const&)
        /ssd/src/gcc/10-branch/gcc/wide-int.h:1262
0xafad7c generic_wide_int<fixed_wide_int_storage<128> >&
generic_wide_int<fixed_wide_int_storage<128>
>::operator=<generic_wide_int<wi::extended_tree<128> >
>(generic_wide_int<wi::extended_tree<128> > const&)
        /ssd/src/gcc/10-branch/gcc/wide-int.h:937
0x1746e1e vrp_prop::check_mem_ref(unsigned int, tree_node*, bool)
        /ssd/src/gcc/10-branch/gcc/tree-vrp.c:3826
0x1748412 check_array_bounds
        /ssd/src/gcc/10-branch/gcc/tree-vrp.c:4050
0x1782e0c walk_tree_1(tree_node**, tree_node* (*)(tree_node**, int*, void*),
void*, hash_set<tree_node*, false, default_hash_traits<tree_node*> >*,
tree_node* (*)(tree_node**, int*, tree_node* (*)(tree_node**, int*, void*),
void*, hash_set<tree_node*, false, default_hash_traits<tree_node*> >*))
        /ssd/src/gcc/10-branch/gcc/tree.c:12000
0xe07e82 walk_gimple_op(gimple*, tree_node* (*)(tree_node**, int*, void*),
walk_stmt_info*)
        /ssd/src/gcc/10-branch/gcc/gimple-walk.c:202
0x1748545 check_array_bounds_dom_walker::before_dom_children(basic_block_def*)
        /ssd/src/gcc/10-branch/gcc/tree-vrp.c:4106
0x2201748 dom_walker::walk(basic_block_def*)
        /ssd/src/gcc/10-branch/gcc/domwalk.c:309
0x17485ac vrp_prop::check_all_array_refs()
        /ssd/src/gcc/10-branch/gcc/tree-vrp.c:4123
0x174ba18 vrp_prop::vrp_finalize(bool)
        /ssd/src/gcc/10-branch/gcc/tree-vrp.c:5195
0x174baad execute_vrp
        /ssd/src/gcc/10-branch/gcc/tree-vrp.c:5263
0x174bcc7 execute
        /ssd/src/gcc/10-branch/gcc/tree-vrp.c:5345
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56456
[Bug 56456] [meta-bug] bogus/missing -Warray-bounds

[Bug tree-optimization/99121] [9/10/11 Regression] ICE tree check: expected integer_cst, have var_decl in get_len, at tree.h:6037

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99121

Martin Sebor <msebor at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #3 from Martin Sebor <msebor at gcc dot gnu.org> ---
Patch: https://gcc.gnu.org/pipermail/gcc-patches/2021-February/565405.html

[Bug tree-optimization/99121] [9/10/11/12 Regression] ICE tree check: expected integer_cst, have var_decl in get_len, at tree.h:6037

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99121

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.4                         |9.5

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.

[Bug tree-optimization/99121] [9/10/11/12 Regression] ICE tree check: expected integer_cst, have var_decl in get_len, at tree.h:6037

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99121

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Sebor <msebor@gcc.gnu.org>:

https://gcc.gnu.org/g:a110855667782dac7b674d3e328b253b3b3c919b

commit r12-2132-ga110855667782dac7b674d3e328b253b3b3c919b
Author: Martin Sebor <msebor@redhat.com>
Date:   Wed Jul 7 14:05:25 2021 -0600

    Correct handling of variable offset minus constant in -Warray-bounds
[PR100137]

    Resolves:
    PR tree-optimization/100137 - -Warray-bounds false positive on varying
offset plus negative
    PR tree-optimization/99121 - ICE in -Warray-bounds on a multidimensional
    PR tree-optimization/97027 - missing warning on buffer overflow storing a
larger scalar into a smaller array

    gcc/ChangeLog:

            PR tree-optimization/100137
            PR tree-optimization/99121
            PR tree-optimization/97027
            * builtins.c (access_ref::access_ref): Also set offmax.
            (access_ref::offset_in_range): Define new function.
            (access_ref::add_offset): Set offmax.
            (access_ref::inform_access): Handle access_none.
            (handle_mem_ref): Clear ostype.
            (compute_objsize_r): Handle ASSERT_EXPR.
            * builtins.h (struct access_ref): Add offmax member.
            * gimple-array-bounds.cc (array_bounds_checker::check_mem_ref): Use
            compute_objsize() and simplify.

    gcc/testsuite/ChangeLog:

            PR tree-optimization/100137
            PR tree-optimization/99121
            PR tree-optimization/97027
            * c-c++-common/Warray-bounds-3.c: Remove xfail
            * c-c++-common/Warray-bounds-4.c: Add an expected warning.
            * c-c++-common/Warray-bounds-9.c: New test.
            * c-c++-common/Warray-bounds-10.c: New test.
            * g++.dg/asan/asan_test.C: Suppress expected warnings.
            * g++.dg/pr95768.C: Same.
            * g++.dg/warn/Warray-bounds-10.C: Adjust text of expected messages.
            * g++.dg/warn/Warray-bounds-11.C: Same.
            * g++.dg/warn/Warray-bounds-12.C: Same.
            * g++.dg/warn/Warray-bounds-13.C: Same.
            * g++.dg/warn/Warray-bounds-17.C: Same.
            * g++.dg/warn/Warray-bounds-20.C: Same.
            * gcc.dg/Warray-bounds-29.c: Same.
            * gcc.dg/Warray-bounds-30.c: Add xfail.
            * gcc.dg/Warray-bounds-31.c: Adjust text of expected messages.
            * gcc.dg/Warray-bounds-32.c: Same.
            * gcc.dg/Warray-bounds-52.c: Same.
            * gcc.dg/Warray-bounds-53.c: Same.
            * gcc.dg/Warray-bounds-58.c: Remove xfail.
            * gcc.dg/Warray-bounds-63.c: Adjust text of expected messages.
            * gcc.dg/Warray-bounds-66.c: Same.
            * gcc.dg/Warray-bounds-69.c: Same.
            * gcc.dg/Wstringop-overflow-34.c: Same.
            * gcc.dg/Wstringop-overflow-47.c: Same.
            * gcc.dg/Wstringop-overflow-61.c: Same.
            * gcc.dg/Warray-bounds-77.c: New test.
            * gcc.dg/Warray-bounds-78.c: New test.
            * gcc.dg/Warray-bounds-79.c: New test.

[Bug tree-optimization/99121] [9/10/11 Regression] ICE tree check: expected integer_cst, have var_decl in get_len, at tree.h:6037

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99121

Martin Sebor <msebor at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|11.0                        |11.1.0
            Summary|[9/10/11/12 Regression] ICE |[9/10/11 Regression] ICE
                   |tree check: expected        |tree check: expected
                   |integer_cst, have var_decl  |integer_cst, have var_decl
                   |in get_len, at tree.h:6037  |in get_len, at tree.h:6037

--- Comment #6 from Martin Sebor <msebor at gcc dot gnu.org> ---
Fixed in GCC 12.0.  The committed patch is too intrusive to backport.

[Bug tree-optimization/99121] [9/10/11 Regression] ICE tree check: expected integer_cst, have var_decl in get_len, at tree.h:6037

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99121

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
But easily fixed with sth like

diff --git a/gcc/gimple-array-bounds.cc b/gcc/gimple-array-bounds.cc
index 199d9f5d216..b1179518651 100644
--- a/gcc/gimple-array-bounds.cc
+++ b/gcc/gimple-array-bounds.cc
@@ -607,6 +607,8 @@ array_bounds_checker::check_mem_ref (location_t location,
tree ref,

       if (TREE_CODE (reftype) == ARRAY_TYPE)
        {
+         if (TREE_CODE (TYPE_SIZE_UNIT (TREE_TYPE (reftype))) != INTEGER_CST)
+           return false;
          /* Set to the size of the array element (and adjust below).  */
          eltsize = wi::to_offset (TYPE_SIZE_UNIT (TREE_TYPE (reftype)));
          /* Use log2 of size to convert the array byte size in to its

no?

[Bug tree-optimization/99121] [9/10/11 Regression] ICE tree check: expected integer_cst, have var_decl in get_len, at tree.h:6037

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99121

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Yeah.  And it changes only behavior for the cases where we'd ICE, so it
shouldn't affect anything where we'd report some useful warning.

[Bug tree-optimization/99121] [9/10/11 Regression] ICE tree check: expected integer_cst, have var_decl in get_len, at tree.h:6037

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99121

Martin Sebor <msebor at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
           Assignee|msebor at gcc dot gnu.org          |unassigned at gcc dot gnu.org

--- Comment #9 from Martin Sebor <msebor at gcc dot gnu.org> ---
Fixed in GCC 12.  It could be fixed on release branches but I'm no longer
working on it.

[Bug tree-optimization/99121] [9/10/11 Regression] ICE tree check: expected integer_cst, have var_decl in get_len, at tree.h:6037

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99121

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:4662984506b774213df9c4429d2c59664bb09adc

commit r11-9787-g4662984506b774213df9c4429d2c59664bb09adc
Author: Richard Biener <rguenther@suse.de>
Date:   Thu Apr 7 11:59:04 2022 +0200

    tree-optimization/99121 - avoid ICEing for non-constant sizes

    The following is a simple fix to avoid ICEing on non-constant
    sizes of ARRAY_REFs instead of backporting too intrusive changes
    done on trunk.

    2022-04-07  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/99121
            * gimple-array-bounds.cc (array_bounds_checker::check_mem_ref):
            Bail out for non-constant type size.

[Bug tree-optimization/99121] [10 Regression] ICE tree check: expected integer_cst, have var_decl in get_len, at tree.h:6037

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99121

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.5                         |10.4

--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9 branch is being closed

[Bug tree-optimization/99121] [10 Regression] ICE tree check: expected integer_cst, have var_decl in get_len, at tree.h:6037

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99121

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.4                        |10.5

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.

[Bug tree-optimization/99121] [10 Regression] ICE tree check: expected integer_cst, have var_decl in get_len, at tree.h:6037

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99121

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.5                        |11.3
             Status|NEW                         |RESOLVED
      Known to fail|                            |10.5.0
         Resolution|---                         |FIXED

--- Comment #13 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed in 11.3