public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jamborm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug ipa/99122] [10/11 Regression] ICE in force_constant_size, at gimplify.c:733 Date: Fri, 19 Feb 2021 10:31:02 +0000 [thread overview] Message-ID: <bug-99122-4-prpNDYlQj1@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-99122-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99122 --- Comment #19 from Martin Jambor <jamborm at gcc dot gnu.org> --- (In reply to Richard Biener from comment #17) > there's variably_modified_type_p (you can pass NULL_TREE for the fndecl) > which is more to the point. Otherwise it looks reasonable. Does IPA CP > do things like IPA SRA and split aggregates? No, it does not split them, the only SRAish thing it does is simple removal of unused register-type parameters. > I wonder in which cases IPA CP would derive "constants" for > aggregates, so why are aggregate parameters even tracked? I am not sure I understand the question. The testcase in comment #12 attempts to pass a simple double constant to what is actually a VLA structure, causing an ICE on undefined behavior input, which is the main thing I want to avoid. But I have just realized that if we now insist that we know all types anyway - I have run the whole C testsuite and did not find any K&R testcase where IPA-CP would consider a parameter for propagation when not knowing its type - we can do something better and only propagate when we know that force_value_to_type would not resort to building a zero constructor. This will allow to still propagate ("aggregate") constants within VLAs like if there was one in b.n in the testcase (and the caller was somewhat saner). > I am testing the following for the inline issue for the last testcase, > leaving the IPA CP one to you. Sure, thanks.
next prev parent reply other threads:[~2021-02-19 10:31 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-16 17:38 [Bug c/99122] New: " gscfq@t-online.de 2021-02-16 18:24 ` [Bug ipa/99122] " jakub at gcc dot gnu.org 2021-02-17 16:38 ` jakub at gcc dot gnu.org 2021-02-17 17:03 ` jamborm at gcc dot gnu.org 2021-02-17 17:10 ` jamborm at gcc dot gnu.org 2021-02-17 17:15 ` jakub at gcc dot gnu.org 2021-02-17 17:52 ` jamborm at gcc dot gnu.org 2021-02-17 17:57 ` jakub at gcc dot gnu.org 2021-02-18 9:09 ` rguenth at gcc dot gnu.org 2021-02-18 11:20 ` rguenth at gcc dot gnu.org 2021-02-18 11:26 ` rguenth at gcc dot gnu.org 2021-02-18 11:27 ` jakub at gcc dot gnu.org 2021-02-18 12:00 ` jakub at gcc dot gnu.org 2021-02-18 12:24 ` jamborm at gcc dot gnu.org 2021-02-18 12:42 ` jamborm at gcc dot gnu.org 2021-02-18 13:38 ` cvs-commit at gcc dot gnu.org 2021-02-18 18:13 ` jamborm at gcc dot gnu.org 2021-02-19 8:37 ` rguenth at gcc dot gnu.org 2021-02-19 8:42 ` rguenth at gcc dot gnu.org 2021-02-19 10:31 ` jamborm at gcc dot gnu.org [this message] 2021-02-19 10:40 ` jakub at gcc dot gnu.org 2021-02-19 10:54 ` rguenther at suse dot de 2021-02-19 13:20 ` cvs-commit at gcc dot gnu.org 2021-02-25 13:01 ` rguenth at gcc dot gnu.org 2021-03-04 14:22 ` jamborm at gcc dot gnu.org 2021-03-05 14:28 ` jamborm at gcc dot gnu.org 2021-03-06 10:54 ` dcb314 at hotmail dot com 2021-03-24 19:28 ` cvs-commit at gcc dot gnu.org 2021-03-29 16:31 ` jakub at gcc dot gnu.org 2021-03-29 16:43 ` jamborm at gcc dot gnu.org 2021-04-08 12:02 ` [Bug ipa/99122] [10 " rguenth at gcc dot gnu.org 2021-06-02 11:27 ` ebotcazou at gcc dot gnu.org 2021-06-02 11:44 ` rguenth at gcc dot gnu.org 2021-06-02 12:25 ` ebotcazou at gcc dot gnu.org 2021-06-02 12:42 ` rguenth at gcc dot gnu.org 2021-06-02 13:03 ` ebotcazou at gcc dot gnu.org 2021-06-03 10:46 ` cvs-commit at gcc dot gnu.org 2021-06-03 10:49 ` cvs-commit at gcc dot gnu.org 2022-06-28 10:43 ` jakub at gcc dot gnu.org 2023-07-07 9:27 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-99122-4-prpNDYlQj1@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).