public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/99133] New: Power10 xxspltiw, xxspltidp, xxsplti32dx instructions need to be marked as prefixed
@ 2021-02-17 14:53 meissner at gcc dot gnu.org
2021-02-17 15:14 ` [Bug target/99133] " meissner at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: meissner at gcc dot gnu.org @ 2021-02-17 14:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99133
Bug ID: 99133
Summary: Power10 xxspltiw, xxspltidp, xxsplti32dx instructions
need to be marked as prefixed
Product: gcc
Version: 11.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: meissner at gcc dot gnu.org
Target Milestone: ---
The power10 instructions added for loading up constants in the vector registers
(xxspltib, xxspltidp, xxsplti32dx) are prefixed instructions, and we need to
set the prefixed attribute, so that the instruction length is correct.
Note unlike the load/store/paddi instructions, these prefixed instructions do
have a 'p' prefix, which means the code in rs6000_final_prescan_insn will have
to be modified so it does not add a 'p' for these cases.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/99133] Power10 xxspltiw, xxspltidp, xxsplti32dx instructions need to be marked as prefixed
2021-02-17 14:53 [Bug target/99133] New: Power10 xxspltiw, xxspltidp, xxsplti32dx instructions need to be marked as prefixed meissner at gcc dot gnu.org
@ 2021-02-17 15:14 ` meissner at gcc dot gnu.org
2021-02-17 16:00 ` meissner at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: meissner at gcc dot gnu.org @ 2021-02-17 15:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99133
--- Comment #1 from Michael Meissner <meissner at gcc dot gnu.org> ---
Note, the comment should read:
Note unlike the load/store/paddi instructions, these prefixed instructions do
NOT have a 'p' prefix, which means the code in rs6000_final_prescan_insn will
have to be modified so it does not add a 'p' for these cases.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/99133] Power10 xxspltiw, xxspltidp, xxsplti32dx instructions need to be marked as prefixed
2021-02-17 14:53 [Bug target/99133] New: Power10 xxspltiw, xxspltidp, xxsplti32dx instructions need to be marked as prefixed meissner at gcc dot gnu.org
2021-02-17 15:14 ` [Bug target/99133] " meissner at gcc dot gnu.org
@ 2021-02-17 16:00 ` meissner at gcc dot gnu.org
2021-02-18 18:52 ` pthaugen at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: meissner at gcc dot gnu.org @ 2021-02-17 16:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99133
Michael Meissner <meissner at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |meissner at gcc dot gnu.org
Last reconfirmed| |2021-02-17
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/99133] Power10 xxspltiw, xxspltidp, xxsplti32dx instructions need to be marked as prefixed
2021-02-17 14:53 [Bug target/99133] New: Power10 xxspltiw, xxspltidp, xxsplti32dx instructions need to be marked as prefixed meissner at gcc dot gnu.org
2021-02-17 15:14 ` [Bug target/99133] " meissner at gcc dot gnu.org
2021-02-17 16:00 ` meissner at gcc dot gnu.org
@ 2021-02-18 18:52 ` pthaugen at gcc dot gnu.org
2021-03-31 19:38 ` cvs-commit at gcc dot gnu.org
2021-03-31 20:00 ` pthaugen at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: pthaugen at gcc dot gnu.org @ 2021-02-18 18:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99133
pthaugen at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pthaugen at gcc dot gnu.org
--- Comment #2 from pthaugen at gcc dot gnu.org ---
I submitted a prefix cleanup patch back in Dec. that also took care of this
https://gcc.gnu.org/pipermail/gcc-patches/2020-December/561591.html. It's still
waiting review.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/99133] Power10 xxspltiw, xxspltidp, xxsplti32dx instructions need to be marked as prefixed
2021-02-17 14:53 [Bug target/99133] New: Power10 xxspltiw, xxspltidp, xxsplti32dx instructions need to be marked as prefixed meissner at gcc dot gnu.org
` (2 preceding siblings ...)
2021-02-18 18:52 ` pthaugen at gcc dot gnu.org
@ 2021-03-31 19:38 ` cvs-commit at gcc dot gnu.org
2021-03-31 20:00 ` pthaugen at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-03-31 19:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99133
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Pat Haugen <pthaugen@gcc.gnu.org>:
https://gcc.gnu.org/g:ea9a39e63eba1ba72aa3608317d1c40ae6bcef55
commit r11-7939-gea9a39e63eba1ba72aa3608317d1c40ae6bcef55
Author: Pat Haugen <pthaugen@linux.ibm.com>
Date: Wed Mar 31 14:37:24 2021 -0500
Update prefixed attribute for Power10.
This patch creates a new attribute, "maybe_prefixed", which is used to mark
those instructions that may have a prefixed form. The existing "prefixed"
attribute is now used to mark all instructions that are prefixed form.
2021-03-31 Pat Haugen <pthaugen@linux.ibm.com>
gcc/
PR target/99133
* config/rs6000/altivec.md (xxspltiw_v4si, xxspltiw_v4sf_inst,
xxspltidp_v2df_inst, xxsplti32dx_v4si_inst, xxsplti32dx_v4sf_inst,
xxblend_<mode>, xxpermx_inst, xxeval): Mark prefixed.
* config/rs6000/mma.md (mma_<vvi4i4i8>, mma_<avvi4i4i8>,
mma_<vvi4i4i2>, mma_<avvi4i4i2>, mma_<vvi4i4>, mma_<avvi4i4>,
mma_<pvi4i2>, mma_<apvi4i2>, mma_<vvi4i4i4>, mma_<avvi4i4i4>):
Likewise.
* config/rs6000/rs6000.c (rs6000_final_prescan_insn): Adjust test.
* config/rs6000/rs6000.md (define_attr "maybe_prefixed"): New.
(define_attr "prefixed"): Update initializer.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/99133] Power10 xxspltiw, xxspltidp, xxsplti32dx instructions need to be marked as prefixed
2021-02-17 14:53 [Bug target/99133] New: Power10 xxspltiw, xxspltidp, xxsplti32dx instructions need to be marked as prefixed meissner at gcc dot gnu.org
` (3 preceding siblings ...)
2021-03-31 19:38 ` cvs-commit at gcc dot gnu.org
@ 2021-03-31 20:00 ` pthaugen at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: pthaugen at gcc dot gnu.org @ 2021-03-31 20:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99133
pthaugen at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #4 from pthaugen at gcc dot gnu.org ---
Fixed.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-31 20:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-17 14:53 [Bug target/99133] New: Power10 xxspltiw, xxspltidp, xxsplti32dx instructions need to be marked as prefixed meissner at gcc dot gnu.org
2021-02-17 15:14 ` [Bug target/99133] " meissner at gcc dot gnu.org
2021-02-17 16:00 ` meissner at gcc dot gnu.org
2021-02-18 18:52 ` pthaugen at gcc dot gnu.org
2021-03-31 19:38 ` cvs-commit at gcc dot gnu.org
2021-03-31 20:00 ` pthaugen at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).