From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 1DA16393BC3B; Mon, 22 Feb 2021 15:51:52 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1DA16393BC3B
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/99174] [modules] ICE with recursive inclusion of header-unit
Date: Mon, 22 Feb 2021 15:51:52 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: nathan at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-99174-4-2Qbw2fK04I@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-99174-4@http.gcc.gnu.org/bugzilla/>
References: <bug-99174-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Feb 2021 15:51:52 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99174

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nathan Sidwell <nathan@gcc.gnu.org>:

https://gcc.gnu.org/g:afed55036b65526be006d55f003f670ebeadb223

commit r11-7324-gafed55036b65526be006d55f003f670ebeadb223
Author: Nathan Sidwell <nathan@acm.org>
Date:   Mon Feb 22 07:43:56 2021 -0800

    c++: Recursing header imports and other duplicates [PR 99174]

    The fix for 98741 introduced two issues.  (a) recursive header units
    iced because we tried to read the preprocessor state after having
    failed to read the config.  (b) we could have duplicate imports of
    named modules in our pending queue, and that would lead to duplicate
    requests for pathnames, which coupled with the use of a null-pathname
    to indicate we'd asked could lead to desynchronization with the module
    mapper.  Fixed by adding a 'visited' flag to module state, so we ask
    exactly once.

            PR c++/99174
            gcc/cp
            * module.cc (struct module_state): Add visited_p flag.
            (name_pending_imports): Use it to avoid duplicate requests.
            (preprocess_module): Don't read preprocessor state if we failed=
 to
            load a module's config.
            gcc/testsuite/
            * g++.dg/modules/pr99174-1_a.C: New.
            * g++.dg/modules/pr99174-1_b.C: New.
            * g++.dg/modules/pr99174-1_c.C: New.
            * g++.dg/modules/pr99174.H: New.=