From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id D0FA93AA941D; Tue, 20 Apr 2021 23:32:48 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D0FA93AA941D
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/99181] char_traits<char> (and thus string_view)
 compares strings differently in constexpr and non-constexpr contexts
Date: Tue, 20 Apr 2021 23:32:48 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-99181-4-a753iMlhgj@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-99181-4@http.gcc.gnu.org/bugzilla/>
References: <bug-99181-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2021 23:32:48 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99181

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:03e18a40070c6fe89397a73d85a38a99371cf8a1

commit r9-9424-g03e18a40070c6fe89397a73d85a38a99371cf8a1
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Feb 23 09:30:18 2021 +0100

    libstdc++: Fix up constexpr std::char_traits<char>::compare [PR99181]

    Because of LWG 467, std::char_traits<char>::lt compares the values
    cast to unsigned char rather than char, so even when char is signed
    we get unsigned comparision.  std::char_traits<char>::compare uses
    __builtin_memcmp and that works the same, but during constexpr evaluati=
on
    we were calling __gnu_cxx::char_traits<char_type>::compare.  As
    char_traits::lt is not virtual, __gnu_cxx::char_traits<char_type>::comp=
are
    used __gnu_cxx::char_traits<char_type>::lt rather than
    std::char_traits<char>::lt and thus compared chars as signed if char is
    signed.
    This change fixes it by inlining __gnu_cxx::char_traits<char_type>::com=
pare
    into std::char_traits<char>::compare by hand, so that it calls the right
    lt method.

    2021-02-23  Jakub Jelinek  <jakub@redhat.com>

            PR libstdc++/99181
            * include/bits/char_traits.h (char_traits<char>::compare): For
            constexpr evaluation don't call
            __gnu_cxx::char_traits<char_type>::compare but do the comparison
loop
            directly.

            * testsuite/21_strings/char_traits/requirements/char/99181.cc: =
New
            test.

    (cherry picked from commit 311c57f6d8f285d69e44bf94152c753900cb1a0a)=