From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 7739B386F80C; Fri, 19 Mar 2021 23:29:44 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7739B386F80C
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/99204] [8/9/10 Regression] ICE in
 fold_read_from_constant_string, at fold-const.c:15441
Date: Fri, 19 Mar 2021 23:29:44 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: ice-on-invalid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 8.5
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-99204-4-4Q56THNJVI@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-99204-4@http.gcc.gnu.org/bugzilla/>
References: <bug-99204-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Mar 2021 23:29:44 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99204

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:f53a9b563b5017af179f1fd900189c0ba83aa2ec

commit r10-9475-gf53a9b563b5017af179f1fd900189c0ba83aa2ec
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Feb 23 09:49:48 2021 +0100

    fold-const: Fix ICE in fold_read_from_constant_string on invalid code
[PR99204]

    fold_read_from_constant_string and expand_expr_real_1 have code to opti=
mize
    constant reads from string (tree vs. rtl).
    If the STRING_CST array type has zero low bound, index is fold converte=
d to
    sizetype and so the compare_tree_int works fine, but if it has some oth=
er
    low bound, it calls size_diffop_loc and that function from 2 sizetype
    operands creates a ssizetype difference.  expand_expr_real_1 then uses
    tree_fits_uhwi_p + compare_tree_int and so works fine, but fold-const.c
    only checked if index is INTEGER_CST and calls compare_tree_int, which
means
    for negative index it will succeed and result in UB in the compiler.

    2021-02-23  Jakub Jelinek  <jakub@redhat.com>

            PR tree-optimization/99204
            * fold-const.c (fold_read_from_constant_string): Check that
            tree_fits_uhwi_p (index) rather than just that index is
INTEGER_CST.

            * gfortran.dg/pr99204.f90: New test.

    (cherry picked from commit 37b64a3547b91677189c6cbf4c08d7c80770a93a)=