public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug analyzer/99212] [11 Regression] gcc.dg/analyzer/data-model-1.c line 971
Date: Fri, 02 Jul 2021 19:22:04 +0000 [thread overview]
Message-ID: <bug-99212-4-t74raFTWH4@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99212-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99212
--- Comment #21 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by David Malcolm
<dmalcolm@gcc.gnu.org>:
https://gcc.gnu.org/g:fa92642b26ee236098ed51752feecc7cf5711f8c
commit r11-8678-gfa92642b26ee236098ed51752feecc7cf5711f8c
Author: David Malcolm <dmalcolm@redhat.com>
Date: Fri Jul 2 15:19:45 2021 -0400
analyzer: bitfield fixes [PR99212]
This patch verifies the previous fix for bitfield sizes by implementing
enough support for bitfields in the analyzer to get the test cases to pass.
The patch implements support in the analyzer for reading from a
BIT_FIELD_REF, and support for folding BIT_AND_EXPR of a mask, to handle
the cases generated in tests.
The existing bitfields tests in data-model-1.c turned out to rely on
undefined behavior, in that they were assigning values to a signed
bitfield that were outside of the valid range of values. I believe that
that's why we were seeing target-specific differences in the test
results (PR analyzer/99212). The patch updates the test to remove the
undefined behaviors.
gcc/analyzer/ChangeLog:
PR analyzer/99212
* region-model-manager.cc
(region_model_manager::maybe_fold_binop): Add support for folding
BIT_AND_EXPR of compound_svalue and a mask constant.
* region-model.cc (region_model::get_rvalue_1): Implement
BIT_FIELD_REF in terms of...
(region_model::get_rvalue_for_bits): New function.
* region-model.h (region_model::get_rvalue_for_bits): New decl.
* store.cc (bit_range::from_mask): New function.
(selftest::test_bit_range_intersects_p): New selftest.
(selftest::assert_bit_range_from_mask_eq): New.
(ASSERT_BIT_RANGE_FROM_MASK_EQ): New macro.
(selftest::assert_no_bit_range_from_mask_eq): New.
(ASSERT_NO_BIT_RANGE_FROM_MASK): New macro.
(selftest::test_bit_range_from_mask): New selftest.
(selftest::analyzer_store_cc_tests): Call the new selftests.
* store.h (bit_range::intersects_p): New.
(bit_range::from_mask): New decl.
(concrete_binding::get_bit_range): New accessor.
(store_manager::get_concrete_binding): New overload taking
const bit_range &.
gcc/testsuite/ChangeLog:
PR analyzer/99212
* gcc.dg/analyzer/bitfields-1.c: New test.
* gcc.dg/analyzer/data-model-1.c (struct sbits): Make bitfields
explicitly signed.
(test_44): Update test values assigned to the bits to ones that
fit in the range of the bitfield type. Remove xfails.
(test_45): Remove xfails.
Signed-off-by: David Malcolm <dmalcolm@redhat.com>
next prev parent reply other threads:[~2021-07-02 19:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 3:35 [Bug analyzer/99212] New: " hp at gcc dot gnu.org
2021-02-23 8:27 ` [Bug analyzer/99212] " rguenth at gcc dot gnu.org
2021-02-23 14:49 ` hp at gcc dot gnu.org
2021-02-25 23:02 ` dmalcolm at gcc dot gnu.org
2021-02-25 23:03 ` dmalcolm at gcc dot gnu.org
2021-02-26 12:58 ` rguenth at gcc dot gnu.org
2021-02-26 14:23 ` dmalcolm at gcc dot gnu.org
2021-02-26 14:33 ` dmalcolm at gcc dot gnu.org
2021-04-04 21:57 ` hp at gcc dot gnu.org
2021-04-09 8:24 ` rguenth at gcc dot gnu.org
2021-04-09 23:11 ` hp at gcc dot gnu.org
2021-04-10 17:45 ` dmalcolm at gcc dot gnu.org
2021-04-12 12:59 ` dmalcolm at gcc dot gnu.org
2021-04-13 2:23 ` hp at gcc dot gnu.org
2021-04-13 2:23 ` cvs-commit at gcc dot gnu.org
2021-04-27 11:40 ` [Bug analyzer/99212] [11/12 " jakub at gcc dot gnu.org
2021-05-04 12:32 ` rguenth at gcc dot gnu.org
2021-06-08 18:46 ` cvs-commit at gcc dot gnu.org
2021-06-08 19:30 ` [Bug analyzer/99212] [11 " dmalcolm at gcc dot gnu.org
2021-06-15 8:05 ` stefansf at linux dot ibm.com
2021-06-15 14:28 ` dmalcolm at gcc dot gnu.org
2021-06-15 21:54 ` cvs-commit at gcc dot gnu.org
2021-06-18 7:36 ` stefansf at linux dot ibm.com
2021-07-02 19:22 ` cvs-commit at gcc dot gnu.org [this message]
2021-07-02 19:22 ` cvs-commit at gcc dot gnu.org
2021-07-02 19:31 ` dmalcolm at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-99212-4-t74raFTWH4@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).