From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id CB3573851C13; Mon, 29 Mar 2021 11:20:05 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CB3573851C13
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/99216] ICE in aarch64_sve::function_expander::expand()
 with LTO
Date: Mon, 29 Mar 2021 11:20:05 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: ice-on-valid-code, patch
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: acoplan at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 10.3
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-99216-4-IVrYPfAHUM@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-99216-4@http.gcc.gnu.org/bugzilla/>
References: <bug-99216-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Mar 2021 11:20:05 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99216

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Alex Coplan <acoplan@gcc.gnu.org>:

https://gcc.gnu.org/g:e4005cf8717abe8c949f840c707e02e6c394c2e7

commit r11-7890-ge4005cf8717abe8c949f840c707e02e6c394c2e7
Author: Alex Coplan <alex.coplan@arm.com>
Date:   Mon Mar 29 12:18:19 2021 +0100

    aarch64: Fix SVE ACLE builtins with LTO [PR99216]

    As discussed in the PR, we currently have two different numbering
    schemes for SVE builtins: one for C, and one for C++. This is
    problematic for LTO, where we end up getting confused about which
    intrinsic we're talking about. This patch inserts placeholders into the
    registered_functions vector to ensure that there is a consistent
    numbering scheme for both C and C++.

    We use integer_zero_node as a placeholder node instead of building a
    function decl. This is safe because the node is only returned by the
    TARGET_BUILTIN_DECL hook, which (on AArch64) is only used for validation
    when builtin decls are streamed into lto1.

    gcc/ChangeLog:

            PR target/99216
            * config/aarch64/aarch64-sve-builtins.cc
            (function_builder::add_function): Add placeholder_p argument, u=
se
            placeholder decls if this is set.
            (function_builder::add_unique_function): Instead of conditional=
ly
adding
            direct overloads, unconditionally add either a direct overload =
or a
            placeholder.
            (function_builder::add_overloaded_function): Set placeholder_p =
if
we're
            using C++ overloads. Use the obstack for string storage instead
            of relying on the tree nodes.
            (function_builder::add_overloaded_functions): Don't return early
for
            m_direct_overloads: we need to add placeholders.
            * config/aarch64/aarch64-sve-builtins.h
            (function_builder::add_function): Add placeholder_p argument.

    gcc/testsuite/ChangeLog:

            PR target/99216
            * g++.target/aarch64/sve/pr99216.C: New test.=