public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/99216] ICE in aarch64_sve::function_expander::expand() with LTO Date: Thu, 22 Apr 2021 13:38:10 +0000 [thread overview] Message-ID: <bug-99216-4-yFltHBF1cO@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-99216-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99216 --- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-10 branch has been updated by Alex Coplan <acoplan@gcc.gnu.org>: https://gcc.gnu.org/g:34a9bc1f95027eea1560369765b8b2b5722b6779 commit r10-9747-g34a9bc1f95027eea1560369765b8b2b5722b6779 Author: Alex Coplan <alex.coplan@arm.com> Date: Thu Apr 22 14:37:12 2021 +0100 aarch64: Fix SVE ACLE builtins with LTO [PR99216] This is a GCC 10 backport of the fix for PR99216 (e4005cf8717abe8c949f840c707e02e6c394c2e7). The only change w.r.t the original patch is a bump of lto-streamer.h:LTO_minor_version. As discussed in the PR, we currently have two different numbering schemes for SVE builtins: one for C, and one for C++. This is problematic for LTO, where we end up getting confused about which intrinsic we're talking about. This patch inserts placeholders into the registered_functions vector to ensure that there is a consistent numbering scheme for both C and C++. This version uses integer_zero_node as a placeholder node instead of building a function decl. This is safe because the node is only returned by the TARGET_BUILTIN_DECL hook, which (on AArch64) is only used for validation when builtin decls are streamed into lto1. gcc/ChangeLog: PR target/99216 * config/aarch64/aarch64-sve-builtins.cc (function_builder::add_function): Add placeholder_p argument, use placeholder decls if this is set. (function_builder::add_unique_function): Instead of conditionally adding direct overloads, unconditionally add either a direct overload or a placeholder. (function_builder::add_overloaded_function): Set placeholder_p if we're using C++ overloads. Use the obstack for string storage instead of relying on the tree nodes. (function_builder::add_overloaded_functions): Don't return early for m_direct_overloads: we need to add placeholders. * config/aarch64/aarch64-sve-builtins.h (function_builder::add_function): Add placeholder_p argument. * lto-streamer.h (LTO_minor_version): Bump. gcc/testsuite/ChangeLog: PR target/99216 * g++.target/aarch64/sve/pr99216.C: New test.
next prev parent reply other threads:[~2021-04-22 13:38 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-23 9:39 [Bug target/99216] New: " acoplan at gcc dot gnu.org 2021-02-23 9:45 ` [Bug target/99216] " ktkachov at gcc dot gnu.org 2021-02-23 10:14 ` acoplan at gcc dot gnu.org 2021-03-04 14:55 ` acoplan at gcc dot gnu.org 2021-03-05 10:00 ` acoplan at gcc dot gnu.org 2021-03-05 11:53 ` rsandifo at gcc dot gnu.org 2021-03-05 12:15 ` acoplan at gcc dot gnu.org 2021-03-29 11:20 ` cvs-commit at gcc dot gnu.org 2021-03-29 11:23 ` acoplan at gcc dot gnu.org 2021-03-30 15:38 ` rsandifo at gcc dot gnu.org 2021-04-08 12:02 ` rguenth at gcc dot gnu.org 2021-04-22 13:38 ` cvs-commit at gcc dot gnu.org [this message] 2021-04-22 13:52 ` acoplan at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-99216-4-yFltHBF1cO@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).