From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 8EA89385800D; Sat, 20 Mar 2021 16:02:54 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8EA89385800D
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug debug/99230] [11 Regression] gcc.dg/pr83527.c excess errors:
 '-fcompare-debug' failure (length)
Date: Sat, 20 Mar 2021 16:02:54 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: debug
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 11.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-99230-4-nEWedJOC9D@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-99230-4@http.gcc.gnu.org/bugzilla/>
References: <bug-99230-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Mar 2021 16:02:54 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99230

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:9f59cb7cac009f3c6eba81eb09714699b9ac9f8d

commit r11-7750-g9f59cb7cac009f3c6eba81eb09714699b9ac9f8d
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Mar 20 17:02:06 2021 +0100

    c-family: Fix PR94272 -fcompare-debug issue even for C [PR99230]

    The following testcase results in -fcompare-debug failure.
    The problem is the similar like in PR94272
    https://gcc.gnu.org/pipermail/gcc-patches/2020-March/542562.html
    When genericizing, with -g0 we have just a TREE_SIDE_EFFECTS DO_STMT
    in a branch of if, while with -g we have that wrapped into
    TREE_SIDE_EFFECTS STATEMENT_LIST containing DEBUG_BEGIN_STMT and that
    DO_STMT.
    The do loop is empty with 0 condition, so c_genericize_control_stmt
    turns it into an empty statement (without TREE_SIDE_EFFECTS).
    For -g0 that means that suddenly the if branch doesn't have side effects
    and is expanded differently.  But with -g we still have TREE_SIDE_EFFEC=
TS
    STATEMENT_LIST containing DEBUG_BEGIN_STMT and non-TREE_SIDE_EFFECTS st=
mt.
    The following patch fixes that by detecting this case and removing
    TREE_SIDE_EFFECTS.

    And, so that we don't duplicate the same code, changes the C++ FE to
    just call the c_genericize_control_stmt function that can now handle it.

    2021-03-20  Jakub Jelinek  <jakub@redhat.com>

            PR debug/99230
            * c-gimplify.c (c_genericize_control_stmt): Handle STATEMENT_LI=
ST.

            * cp-gimplify.c (cp_genericize_r) <case STATEMENT_LIST>: Remove
            special code, instead call c_genericize_control_stmt.

            * gcc.dg/pr99230.c: New test.=