public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "msebor at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/99251] [11 Regression] inconsistent -Wnonnull warning behaviour with dynamic_cast Date: Wed, 24 Feb 2021 17:12:27 +0000 [thread overview] Message-ID: <bug-99251-4-b0uPQBbXgA@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-99251-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99251 Martin Sebor <msebor at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |95507 Last reconfirmed| |2021-02-24 Keywords| |diagnostic Summary|Strange -Wnonnull warning |[11 Regression] |behaviour with dynamic_cast |inconsistent -Wnonnull | |warning behaviour with | |dynamic_cast Ever confirmed|0 |1 CC| |msebor at gcc dot gnu.org Status|UNCONFIRMED |NEW --- Comment #1 from Martin Sebor <msebor at gcc dot gnu.org> --- We discussed this instance of the warning in pr98646 and decided that even though issuing it for an access to the result of dynamic_cast was strictly a false positive when the operand was guaranteed to be nonnull by a prior test, the workaround to cast to a reference rather than a pointer was simple enough and made the intent clearer: return dynamic_cast<cl2 &>(*p).i(); But the inconsistency exhibited in this test case is not a good thing (enclosing the cast in parentheses certainly shouldn't make a difference) and suggests the decision should be revisited. The warning for the dynamic_cast should either be issued consistently or not at all. Let me look into it. Referenced Bugs: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95507 [Bug 95507] [meta-bug] bogus/missing -Wnonnull
next prev parent reply other threads:[~2021-02-24 17:12 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-24 16:21 [Bug c++/99251] New: Strange " sirl at gcc dot gnu.org 2021-02-24 17:12 ` msebor at gcc dot gnu.org [this message] 2021-02-24 17:13 ` [Bug c++/99251] [11 Regression] inconsistent " msebor at gcc dot gnu.org 2021-02-24 18:14 ` msebor at gcc dot gnu.org 2021-02-24 22:29 ` msebor at gcc dot gnu.org 2021-02-25 7:59 ` rguenth at gcc dot gnu.org 2021-03-02 18:17 ` cvs-commit at gcc dot gnu.org 2021-03-02 18:18 ` msebor at gcc dot gnu.org 2021-06-28 20:13 ` msebor at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-99251-4-b0uPQBbXgA@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).