public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "kargl at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/99256] ICE in variable_check, at fortran/check.c:1012
Date: Thu, 13 Jan 2022 23:08:38 +0000	[thread overview]
Message-ID: <bug-99256-4-xomonx07k3@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99256-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99256

--- Comment #5 from kargl at gcc dot gnu.org ---
(In reply to anlauf from comment #4)
> (In reply to anlauf from comment #3)
> 
> Even simpler fix, as intrinsics do not accept alternate return specifiers:
> 
> diff --git a/gcc/fortran/intrinsic.c b/gcc/fortran/intrinsic.c
> index a7ecdb401ef..4e5ec966d94 100644
> --- a/gcc/fortran/intrinsic.c
> +++ b/gcc/fortran/intrinsic.c
> @@ -4420,7 +4420,7 @@ do_sort:
>    FOR_EACH_VEC_ELT (dummy_args, idx, f)
>      {
>        a = ordered_actual_args[idx];
> -      if (a && a->label != NULL && f->ts.type)
> +      if (a && a->label != NULL)
>         {
>           gfc_error ("ALTERNATE RETURN not permitted at %L", where);
>           return false;

If this survives regression testing, it certainly seems to fall into the
obviously correct category.  I think you can commit the patch.

  parent reply	other threads:[~2022-01-13 23:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24 17:31 [Bug fortran/99256] New: " gscfq@t-online.de
2021-02-25 18:40 ` [Bug fortran/99256] " kargl at gcc dot gnu.org
2021-02-25 18:49 ` sgk at troutmask dot apl.washington.edu
2021-12-12 21:47 ` anlauf at gcc dot gnu.org
2022-01-13 22:39 ` anlauf at gcc dot gnu.org
2022-01-13 23:08 ` kargl at gcc dot gnu.org [this message]
2022-01-14 20:48 ` cvs-commit at gcc dot gnu.org
2022-01-14 20:57 ` anlauf at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99256-4-xomonx07k3@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).